docs: credit upstream sources, add AGPL-3.0, fix seriaati misattribution - #3
Merged
Conversation
Adds a Sources section documenting the three upstreams and how they are merged (first source wins, later ones fill blank rewards, tolerate partial failure), plus a Credits section naming the authors. Corrects the intro link: "OpenGachaCodes" pointed at config.example.yaml rather than the project it names. Licenses the project AGPL-3.0. The network-use clause is the point — a notifier daemon is appropriated by being run as a hosted service, not by being distributed, which plain GPL would not cover. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The hoyo-codes.seria.moe API is seriaati's (seriaati/hoyo-codes), not torikushiii's. The Tori field name and several comments credited the wrong author, and AGENTS.md paired torikushiii's repo URL with seriaati's endpoint. Renames Game.Tori to Seria, fetchTori to fetchSeria, and the "tori" source label to "seria" (visible in partial-failure logs). torikushiii is still credited where correct: api.ennead.cc is their hoyoverse-api, as is OpenGachaCodes. Ennead keeps its name — it is the endpoint host, not an author. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds source/credit documentation, licenses the project, and fixes an attribution error the docs work uncovered.
Two commits
1.
docs:— Sources + Credits + LICENSE[OpenGachaCodes](config.example.yaml)used the project's name but pointed at our own config template.LICENSE(canonical AGPL-3.0, via the GitHub license API).2.
refactor:— fix misattributionhoyo-codes.seria.moeis seriaati's (seriaati/hoyo-codes), but the code credited torikushiii throughout.AGENTS.mdeven paired torikushiii's repo URL with seriaati's endpoint.Game.Tori→Game.Seria,fetchTori→fetchSeria, source label"tori"→"seria"(appears in partial-failure logs).api.ennead.ccis theirhoyoverse-api, as is OpenGachaCodes.Enneadkeeps its name: it's the endpoint host, not an author.Verified upstream
OpenGachaCodes declares no license, so none is claimed for it in Credits. We consume all three over HTTP without linking or redistributing, so their copyleft imposes nothing here.
Why AGPL-3.0
A notifier daemon gets appropriated by being run as a hosted service, not by being distributed — so GPL-3.0's distribution trigger would never fire. AGPL §13 covers network use, which is the case that matters. Dependencies (
robfig/cronMIT,yaml.v3MIT/Apache-2.0) are permissive and compatible.Testing
gofmt,go build,go vet,go testall pass.markExistingOnFirstRun: trueand a scratch data dir, so nothing was posted to Discord.🤖 Generated with Claude Code