docs: rename project to gacha-codes-notifier, link @exec-astraea - #4
Merged
Merged
Conversation
The README still called the project hoyo-codes, which no longer matches the repository. Renames the heading and the Docker image/container names in the run example, and makes the @exec-astraea credit an actual link. References to seriaati/hoyo-codes are left alone — that is a different project that genuinely has that name. Also updates the User-Agent sent to the upstream APIs: it advertised github.com/exec-astraea/hoyo-codes, which 404s (no redirect). The whole point of the +URL is letting API operators identify the client, so a dead link defeats it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README still called the project
hoyo-codes, which no longer matches the repository name.Changes
gacha-codes-notifier.gacha-codes-notifier(the tag is independent of the binary inside the image, so the example still works as-is).@exec-astraeain the License line was plain text — now links to https://github.com/exec-astraea.User-Agentinsources.goadvertisedgithub.com/exec-astraea/hoyo-codes, which returns a hard 404 with no redirect. Now points at the real repo.Deliberately not renamed
References to seriaati/hoyo-codes in Sources/Credits — that's a different project that legitimately has that name.
Still stale (not in this PR — say if you want them)
go.mod:1module github.com/exec-astraea/hoyo-codesDockerfilehoyo-codesmain.go:48hoyo-codes starting: …AGENTS.md:1# hoyo-codes — agent guideconfig.example.yaml:1# hoyo-codes configuration.The
go.modpath is the notable one: it doesn't match the repo URL, sogo install github.com/exec-astraea/gacha-codes-notifier@latestwould fail on a module-path mismatch. Harmless for local builds and Docker, since nothing imports this module.gofmt,go build,go vet,go testall pass.🤖 Generated with Claude Code