Update baffling-birthdays/.meta/example.sh

Co-authored-by: IsaacG

Author: resu-xuniL

exercises/practice/baffling-birthdays/.meta/example.sh

@@ -13,7 +13,7 @@ sharedBirthday () {
     for birthdate in "${birthdates[@]}"; do
         birthday=${birthdate: -5}
 
-        (( birthdays[$birthday] ++ ))
+        (( birthdays[$birthday]++ ))
     done
 
     if (( ${#birthdays[@]} == ${#birthdates[@]} )); then
@@ -59,18 +59,14 @@ estimatedProbabilityOfSharedBirthday () {
     # but the more you increase the computing time!
     local -i runs=1000
     local -i count=0
-    local result
-
 
     for ((i = 0; i <= runs; i++)); do
         if [[ $(sharedBirthday $(randomBirthdates $group_size)) == "true" ]]; then
             (( ++ count ))
         fi
     done
 
-    result="$(LC_NUMERIC=C printf "%.2f\n" "$(echo "scale=2; ($count * 100) / $runs" | bc)")"
-
-    echo "$result"
+    bc <<< "scale=2; $count * 100 / $runs"
 }
 
 main "$@"

exercises/practice/baffling-birthdays/baffling_birthdays.bats

@@ -92,17 +92,17 @@ load bats-extra
 @test "random birthdates -> generate requested number of birthdates" {
     [[ $BATS_RUN_SKIPPED == "true" ]] || skip
     generate=$(shuf -n 1 -i 100-1000)
-    run bash baffling_birthdays.sh randomBirthdates $generate
+    run bash baffling_birthdays.sh randomBirthdates "$generate"
     assert_success
     read -ra output_dates <<< "$output"
-    assert_equal ${#output_dates[@]} $generate
+    assert_equal ${#output_dates[@]} "$generate"
 }
 
 @test "random birthdates -> years are not leap years" {
     [[ $BATS_RUN_SKIPPED == "true" ]] || skip
     generate=$(shuf -n 1 -i 100-1000)
     seen_leap=0
-    run bash baffling_birthdays.sh randomBirthdates $generate
+    run bash baffling_birthdays.sh randomBirthdates "$generate"
     assert_success
     read -ra output_dates <<< "$output"
     for date in "${output_dates[@]}"; do
@@ -111,14 +111,14 @@ load bats-extra
             (( ++ seen_leap ))
         fi
     done
-    assert_equal $seen_leap 0
+    assert_equal ${seen_leap} 0
 }
 
 @test "random birthdates -> months are random" {
     [[ $BATS_RUN_SKIPPED == "true" ]] || skip
     declare -A seen_month
     generate=$(shuf -n 1 -i 100-1000)
-    run bash baffling_birthdays.sh randomBirthdates $generate
+    run bash baffling_birthdays.sh randomBirthdates "$generate"
     assert_success
     read -ra output_dates <<< "$output"
     for date in "${output_dates[@]}"; do
@@ -133,7 +133,7 @@ load bats-extra
     [[ $BATS_RUN_SKIPPED == "true" ]] || skip
     declare -A seen_day
     generate=$(shuf -n 1 -i 100-1000)
-    run bash baffling_birthdays.sh randomBirthdates $generate
+    run bash baffling_birthdays.sh randomBirthdates "$generate"
     assert_success
     read -ra output_dates <<< "$output"
     for date in "${output_dates[@]}"; do
@@ -150,29 +150,29 @@ load bats-extra
     # expect="0.0" # this is the exercice ref.
     run bash baffling_birthdays.sh estimatedProbabilityOfSharedBirthday 1
     assert_success
-   [[ "$output" =~ ^(0\.) ]]
+	assert_equal "$output" 0
 }
 
 @test "estimated probability of at least one shared birthday -> among ten people" {
     [[ $BATS_RUN_SKIPPED == "true" ]] || skip
     # expect="11.694818" # this is the exercice ref.
     run bash baffling_birthdays.sh estimatedProbabilityOfSharedBirthday 10
     assert_success
-    [[ "$output" =~ ^(10\.|11\.|12\.|13\.|14\.) ]]
+    [[ $output =~ ^(10\.|11\.|12\.|13\.|14\.) ]]
 }
 
 @test "estimated probability of at least one shared birthday -> among twenty-three people" {
     [[ $BATS_RUN_SKIPPED == "true" ]] || skip
     # expect="50.729723" # this is the exercice ref.
     run bash baffling_birthdays.sh estimatedProbabilityOfSharedBirthday 23
     assert_success
-    [[ "$output" =~ ^(48\.|49\.|50\.|51\.|52\.|53\.) ]]
+    [[ $output =~ ^(48\.|49\.|50\.|51\.|52\.|53\.) ]]
 }
 
 @test "estimated probability of at least one shared birthday -> among seventy people" {
     [[ $BATS_RUN_SKIPPED == "true" ]] || skip
     # expect="99.915958" # this is the exercice ref.
     run bash baffling_birthdays.sh estimatedProbabilityOfSharedBirthday 70
     assert_success
-    [[ "$output" =~ ^(98\.|99\.|100\.) ]]
+    [[ $output =~ ^(98\.|99\.|100\.) ]]
 }