Use snprintf instead of sprintf#1086
Merged
Merged
Conversation
ahans
force-pushed
the
ahans/sprintf-fixes-apple-clang
branch
from
2bf7563 to
6c50449
Compare
ryanplusplus
approved these changes
Aug 19, 2025
Member
ryanplusplus
left a comment
ryanplusplus
left a comment
There was a problem hiding this comment.
Looks good once CI is happy
`sprintf` has been deprecated on macOS and a warning is issued when using it. `-Werror` turns the warning into an error, consequently tests don't pass on macOS. This fixes this by using `snprintf` instead.
ahans
force-pushed
the
ahans/sprintf-fixes-apple-clang
branch
from
6c50449 to
05df667
Compare
Contributor
Author
Not sure why this works on macOS, it didn't make much sense. One of the rare cases where I tried having Copilot do all the editing. It figured out which files needed some modificiations and also interpreted the error message correctly (we need to replace |
ahans
added a commit
to ahans/c
that referenced
this pull request
Aug 20, 2025
This reverts commit f5b7fe1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sprintfhas been deprecated on macOS and a warning is issued when using it.-Werrorturns the warning into an error, consequently tests don't pass on macOS. This fixes this by usingsnprintfinstead.