Merge branch 'main' into tests--update-reverse-string-exercise

Author: vaeng

.github/workflows/ci.yml

@@ -11,16 +11,16 @@ on:
 jobs:
   linux-min:
     name: Linux Min Config
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     strategy:
       matrix:
-        compiler: [clang++-6.0, g++-10]
+        compiler: [clang++-15, g++-12]
     steps:
-    - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
+    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
     - name: Install Dependencies
       # Boost must be installed only because the CMake version (3.12) can't
       # detect the installed Boost version (1.69)
-      run: sudo apt-get update && sudo apt-get -y install ninja-build libboost-date-time-dev clang-6.0 g++-10 g++-multilib
+      run: sudo apt-get update && sudo apt-get -y install ninja-build libboost-date-time-dev g++-multilib
     - name: Run tests with common Catch
       run: |
         cmake -G Ninja .
@@ -32,12 +32,12 @@ jobs:
   linux-latest:
     name: Linux Latest Config
     needs: [linux-min]
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     strategy:
       matrix:
         compiler: [clang++, g++]
     steps:
-    - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
+    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
     - name: Install Dependencies
       # Boost must be installed only because the CMake version (3.12) can't
       # detect the installed Boost version (1.69)
@@ -64,7 +64,7 @@ jobs:
     needs: [linux-min]
     runs-on: windows-2022
     steps:
-    - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
+    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
     - name: Run Tests
       shell: powershell
       # Delete the exercises that require Boost to avoid issues with Windows setup.
@@ -80,7 +80,7 @@ jobs:
     needs: [linux-min]
     runs-on: macOS-latest
     steps:
-    - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
+    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
     - name: Install Boost
       run: brew install boost
     - name: Run Tests

.github/workflows/hello-world.yml

@@ -21,7 +21,7 @@ jobs:
     name: Hello World Fails
     runs-on: ubuntu-22.04
     steps:
-    - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
+    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
     - name: Check Hello World Fails
       run: bin/check-hello-world.sh
       env:

.github/workflows/pre-commit.yml

@@ -0,0 +1,26 @@
+name: Pre-commit checks
+
+on:
+  # Run workflow for PRs.
+  pull_request:
+
+  # Whenever we have a new commit on main, run the workflow for that.
+  push:
+    branches: [main]
+
+jobs:
+  pre-commit:
+    name: Pre-commit checks
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          ref: ${{github.event.pull_request.head.sha}}
+          repository: ${{github.event.pull_request.head.repo.full_name}}
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.10"
+      - name: Run pre-commit checks on PR
+        uses: pre-commit/action@v3.0.1

.github/workflows/verify-code-formatting.yml

@@ -0,0 +1,9 @@
+exclude: 'test/(catch.hpp|tests-main.cpp)'
+
+repos:
+-   repo: https://github.com/pre-commit/mirrors-clang-format
+    rev: v18.1.2
+    hooks:
+    -   id: clang-format
+        exclude_types: [json]
+

.pre-commit-config.yaml

@@ -1,23 +1,31 @@
 cmake_minimum_required(VERSION 3.5.1)
 project(exercism CXX)
 
-set(alt_exercise_tree ${CMAKE_CURRENT_SOURCE_DIR}/build_exercises/practice)
-
-function(build_fixup exercise_dir alt_exercise_root)
+function(build_fixup exercise_dir alt_exercise_root exercise_type example_name)
     string(REPLACE "-" "_" file ${exercise_dir})
-    set(source ${CMAKE_CURRENT_SOURCE_DIR}/exercises/practice/${exercise_dir})
+    set(source ${CMAKE_CURRENT_SOURCE_DIR}/exercises/${exercise_type}/${exercise_dir})
     if(EXISTS ${source})
         set(alt_exercise_dir ${alt_exercise_root}/${exercise_dir})
         file(COPY ${source} DESTINATION ${alt_exercise_root})
-        if(EXISTS ${alt_exercise_dir}/.meta/example.h)
-            file(RENAME ${alt_exercise_dir}/.meta/example.h ${alt_exercise_dir}/${file}.h)
+        if(EXISTS ${alt_exercise_dir}/.meta/${example_name}.h)
+            file(RENAME ${alt_exercise_dir}/.meta/${example_name}.h ${alt_exercise_dir}/${file}.h)
         endif()
-        if(EXISTS ${alt_exercise_dir}/.meta/example.cpp)
-            file(RENAME ${alt_exercise_dir}/.meta/example.cpp ${alt_exercise_dir}/${file}.cpp)
+        if(EXISTS ${alt_exercise_dir}/.meta/${example_name}.cpp)
+            file(RENAME ${alt_exercise_dir}/.meta/${example_name}.cpp ${alt_exercise_dir}/${file}.cpp)
         endif()
     endif()
 endfunction()
 
+function(add_exercises exercise_type example_name)
+    file(GLOB exercise_list ${CMAKE_CURRENT_SOURCE_DIR}/exercises/${exercise_type}/*)
+    set(alt_exercise_tree ${CMAKE_CURRENT_SOURCE_DIR}/build_exercises/${exercise_type})
+    foreach(exercise_dir ${exercise_list})
+        get_filename_component(exercise ${exercise_dir} NAME)
+        build_fixup(${exercise} ${alt_exercise_tree} ${exercise_type} ${example_name})
+        add_subdirectory(${alt_exercise_tree}/${exercise})
+    endforeach()
+endfunction()
+
 option(EXERCISM_RUN_ALL_TESTS "Run all Exercism tests" On)
 option(EXERCISM_COMMON_CATCH "Link against a common Catch2 main lib." On)
 
@@ -30,10 +38,5 @@ if(EXERCISM_COMMON_CATCH)
     )
 endif()
 
-file(GLOB exercise_list ${CMAKE_CURRENT_SOURCE_DIR}/exercises/practice/*)
-
-foreach(exercise_dir ${exercise_list})
-    get_filename_component(exercise ${exercise_dir} NAME)
-    build_fixup(${exercise} ${alt_exercise_tree})
-    add_subdirectory(${alt_exercise_tree}/${exercise})
-endforeach()
+add_exercises("concept" "exemplar")
+add_exercises("practice" "example")

CMakeLists.txt

@@ -21,10 +21,8 @@ for exercise_dir in "${exercises_dir}"/*; do
     header="$exercise_name.h"
     source="$exercise_name.cpp"
     if ! test -f "$header"; then
-        printf "#if !defined(${exercise_name^^}_H)\n" >> $header
-        printf "#define ${exercise_name^^}_H\n" >> $header
+        printf "#pragma once\n" >> $header
         printf "\nnamespace $exercise_name {\n\n}  // namespace $exercise_name\n" >> $header
-        printf "\n#endif // ${exercise_name^^}_H" >> $header
         git add $header
     fi
     if ! test -f "$source"; then

bin/check-formatting.sh

@@ -33,6 +33,15 @@ auto net_worth_carlisle_cullen{46'000'000'000LL}; // int and uint are not enough
 Floating-point numbers usually resolve to `double` during compilation.
 This is a good default case and use-cases with the narrower `float` type are less frequent than the unsigned example above.
 
+~~~~exercism/advanced
+The [C++23 standard][cpp23-literals] introduces more fine grained control with literals like `f128` or `F16`.
+Some compilers allow their own literals.
+GCC permits the usage of `d` as a literal, but this is not foreseen in the standard and can hinder cross-platform compatibility.
+
+[cpp23-literals]: https://en.cppreference.com/w/cpp/language/floating_literal
+
+~~~~
+
 ```cpp
 auto light_year_in_m{9.46073e+15f}; // well in the range of float
 auto earth_to_edge_comoving_distance_in_nm{4.32355e+32}; // needs double type for magnitude

bin/make-stub-files.sh

@@ -60,7 +60,7 @@ Consider also that we are only assigning the value of `width` to `length` at the
 Therefore, if the value of `width` changes at a later moment, it will not affect the value taken by `length`.
 
 Assignment operator can be combined with the other operators(arithmetic & bitwise) known as `compound assignment` operators `+=`, `-=`, `*=`, `/=`, `%=`.
-These operators modifies the current value of a variable by performing an operation on it.
+These operators modify the current value of a variable by performing an operation on it.
 
 ```cpp
 // we start with 0 people