simple-linked-list: address review feedback

Author: AdityaPudasaini

exercises/practice/simple-linked-list/.meta/tests.toml

@@ -76,12 +76,15 @@ description = "toList LIFO -> To list after a pop"
 
 [03fc83a5-48a8-470b-a2d2-a286c5e8365f]
 description = "toList FIFO -> Empty linked list to list is empty"
+include = false
 
 [1282484e-a58c-426a-972e-90746bda61fc]
 description = "toList FIFO -> To list with multiple values"
+include = false
 
 [05ca3109-1249-4c0c-a567-a3b2f8352a7c]
 description = "toList FIFO -> To list after a pop"
+include = false
 
 [5e6c1a3d-e34b-46d3-be59-3f132a820ed5]
 description = "reverse -> Reversed empty list has same values"

exercises/practice/simple-linked-list/src/test/java/SimpleLinkedListTest.java

@@ -7,87 +7,6 @@
 
 public class SimpleLinkedListTest {
 
-    @Test
-    @DisplayName("A new list is empty")
-    public void aNewListIsEmpty() {
-        SimpleLinkedList<Integer> list = new SimpleLinkedList<>();
-        assertThat(list.size()).isEqualTo(0);
-    }
-
-    @Disabled("Remove to run test")
-    @Test
-    @DisplayName("Create list from array")
-    public void canCreateFromArray() {
-        Character[] values = new Character[]{'1', '2', '3'};
-        SimpleLinkedList<Character> list = new SimpleLinkedList<Character>(values);
-        assertThat(list.size()).isEqualTo(3);
-    }
-
-    @Disabled("Remove to run test")
-    @Test
-    @DisplayName("Popping an empty list throws NoSuchElementException")
-    public void popOnEmptyListWillThrow() {
-        SimpleLinkedList<String> list = new SimpleLinkedList<String>();
-        assertThatExceptionOfType(NoSuchElementException.class).isThrownBy(list::pop);
-    }
-
-    @Disabled("Remove to run test")
-    @Test
-    @DisplayName("Pop returns last added element (LIFO)")
-    public void popReturnsLastAddedElement() {
-        SimpleLinkedList<Integer> list = new SimpleLinkedList<Integer>();
-        list.push(9);
-        list.push(8);
-        assertThat(list.size()).isEqualTo(2);
-        assertThat(list.pop()).isEqualTo(8);
-        assertThat(list.pop()).isEqualTo(9);
-        assertThat(list.size()).isEqualTo(0);
-    }
-
-    @Disabled("Remove to run test")
-    @Test
-    @DisplayName("Reverse reverses the list order")
-    public void reverseReversesList() {
-        SimpleLinkedList<String> list = new SimpleLinkedList<String>();
-        list.push("9");
-        list.push("8");
-        list.push("7");
-        list.push("6");
-        list.push("5");
-        list.reverse();
-        assertThat(list.pop()).isEqualTo("9");
-        assertThat(list.pop()).isEqualTo("8");
-        assertThat(list.pop()).isEqualTo("7");
-        assertThat(list.pop()).isEqualTo("6");
-        assertThat(list.pop()).isEqualTo("5");
-    }
-
-    @Disabled("Remove to run test")
-    @Test
-    @DisplayName("Can return list as an array")
-    public void canReturnListAsArray() {
-        SimpleLinkedList<Character> list = new SimpleLinkedList<Character>();
-        list.push('9');
-        list.push('8');
-        list.push('7');
-        list.push('6');
-        list.push('5');
-        Character[] expected = {'5', '6', '7', '8', '9'};
-        assertThat(list.asArray(Character.class)).isEqualTo(expected);
-    }
-
-    @Disabled("Remove to run test")
-    @Test
-    @DisplayName("Can return empty list as an empty array")
-    public void canReturnEmptyListAsEmptyArray() {
-        SimpleLinkedList<Object> list = new SimpleLinkedList<Object>();
-        Object[] expected = {};
-        assertThat(list.asArray(Object.class)).isEqualTo(expected);
-    }
-
-    // count tests
-
-    @Disabled("Remove to run test")
     @Test
     @DisplayName("count -> Empty list has length of zero")
     public void countEmptyListHasLengthOfZero() {
@@ -111,8 +30,6 @@ public void countNonEmptyListHasCorrectLength() {
         assertThat(list.size()).isEqualTo(3);
     }
 
-    // pop tests
-
     @Disabled("Remove to run test")
     @Test
     @DisplayName("pop -> Pop from empty list is an error")
@@ -158,8 +75,6 @@ public void popUpdatesTheCount() {
         assertThat(list.size()).isEqualTo(0);
     }
 
-    // push tests
-
     @Disabled("Remove to run test")
     @Test
     @DisplayName("push -> Can push to an empty list")
@@ -202,8 +117,6 @@ public void pushAndPop() {
         assertThat(list.size()).isEqualTo(0);
     }
 
-    // peek tests
-
     @Disabled("Remove to run test")
     @Test
     @DisplayName("peek -> Peek on empty list is an error")
@@ -251,8 +164,6 @@ public void canPeekAfterAPopAndPush() {
         assertThat(list.peek()).isEqualTo(3);
     }
 
-    // toList tests
-
     @Disabled("Remove to run test")
     @Test
     @DisplayName("toList LIFO -> Empty linked list to list is empty")
@@ -282,37 +193,6 @@ public void toListLifoToListAfterAPop() {
         assertThat(list.toList()).containsExactly(4, 2, 1);
     }
 
-    @Disabled("Remove to run test")
-    @Test
-    @DisplayName("toList FIFO -> Empty linked list to list is empty")
-    public void toListFifoEmptyLinkedListToListIsEmpty() {
-        SimpleLinkedList<Integer> list = new SimpleLinkedList<>();
-        assertThat(list.toList()).isEmpty();
-    }
-
-    @Disabled("Remove to run test")
-    @Test
-    @DisplayName("toList FIFO -> To list with multiple values")
-    public void toListFifoToListWithMultipleValues() {
-        SimpleLinkedList<Integer> list = new SimpleLinkedList<>(new Integer[]{1, 2, 3});
-        assertThat(list.toList()).containsExactly(1, 2, 3);
-    }
-
-    @Disabled("Remove to run test")
-    @Test
-    @DisplayName("toList FIFO -> To list after a pop")
-    public void toListFifoToListAfterAPop() {
-        SimpleLinkedList<Integer> list = new SimpleLinkedList<>();
-        list.push(1);
-        list.push(2);
-        list.push(3);
-        assertThat(list.pop()).isEqualTo(3);
-        list.push(4);
-        assertThat(list.toList()).containsExactly(4, 2, 1);
-    }
-
-    // reverse tests
-
     @Disabled("Remove to run test")
     @Test
     @DisplayName("reverse -> Reversed empty list has same values")
@@ -354,4 +234,36 @@ public void doubleReverse() {
         assertThat(list.pop()).isEqualTo(2);
         assertThat(list.pop()).isEqualTo(3);
     }
+
+    @Disabled("Remove to run test")
+    @Test
+    @DisplayName("Can return list as an array")
+    public void canReturnListAsArray() {
+        SimpleLinkedList<Character> list = new SimpleLinkedList<Character>();
+        list.push('9');
+        list.push('8');
+        list.push('7');
+        list.push('6');
+        list.push('5');
+        Character[] expected = {'5', '6', '7', '8', '9'};
+        assertThat(list.asArray(Character.class)).isEqualTo(expected);
+    }
+
+    @Disabled("Remove to run test")
+    @Test
+    @DisplayName("Can return empty list as an empty array")
+    public void canReturnEmptyListAsEmptyArray() {
+        SimpleLinkedList<Object> list = new SimpleLinkedList<Object>();
+        Object[] expected = {};
+        assertThat(list.asArray(Object.class)).isEqualTo(expected);
+    }
+
+    @Disabled("Remove to run test")
+    @Test
+    @DisplayName("Create list from array")
+    public void canCreateFromArray() {
+        Character[] values = new Character[]{'1', '2', '3'};
+        SimpleLinkedList<Character> list = new SimpleLinkedList<Character>(values);
+        assertThat(list.size()).isEqualTo(3);
+    }
 }