Merge branch 'exercism:main' into main

Author: shreyasgosavi

.github/workflows/check-deprecated-exercises.yml

@@ -0,0 +1,21 @@
+name: Deprecated
+
+on:
+  pull_request:
+    paths:
+      - "exercises/**"
+  push:
+    branches:
+      - main
+  workflow_dispatch:
+
+jobs:
+  test-deprecated:
+    name: Check for deprecated exercises
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
+        with:
+          fetch-depth: 0
+      - name: Test deprecated exercises using test-deprecated-exercises
+        run: bin/test-deprecated-exercises

.github/workflows/java.yml

@@ -15,11 +15,11 @@ jobs:
     name: Check if tests compile cleanly with starter sources
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
-      - name: Set up JDK 1.17
-        uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
+      - name: Set up JDK 21
+        uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654
         with:
-          java-version: 17
+          java-version: 21
           distribution: "temurin"
       - name: Check if tests compile cleanly with starter sources
         run: ./gradlew compileStarterTestJava --continue
@@ -29,26 +29,70 @@ jobs:
     name: Lint Java files using Checkstyle
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
-      - name: Set up JDK 1.17
-        uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
+      - name: Set up JDK 21
+        uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654
         with:
-          java-version: 17
+          java-version: 21
           distribution: "temurin"
       - name: Run checkstyle
         run: ./gradlew check --exclude-task test --continue
         working-directory: exercises
 
-  test:
+  test-all:
     name: Test all exercises using java-test-runner
+    if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
       - name: Test all exercises using java-test-runner
         run: bin/test-with-test-runner
+      - name: Print summary
+        run: |
+          if [ -f exercises/build/summary.txt ]; then
+            echo "===== TEST SUMMARY ====="
+            cat exercises/build/summary.txt
+            echo "========================"
+          else
+            echo "===== ALL TESTS PASSED ====="
+            echo "No summary file was generated."
+            echo "============================="
+          fi
+        if: always() 
       - name: Archive test results
-        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
+        uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a
         with:
           name: test-results
           path: exercises/**/build/results.json
         if: failure()
+        
+  test-changed:
+    name: Test changed exercises using gradlew
+    if: github.event_name == 'pull_request'
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
+        with:
+          fetch-depth: 0
+      - name: Test changed exercises using java-test-runner
+        run: bin/test-changed-exercise
+      - name: Print summary
+        run: |
+          if [ -f exercises/build/summary.txt ]; then
+            echo "===== TEST SUMMARY ====="
+            cat exercises/build/summary.txt
+            echo "========================"
+          else
+            echo "===== ALL TESTS PASSED ====="
+            echo "No summary file was generated."
+            echo "============================="
+          fi
+        if: always() 
+      - name: Archive test results
+        uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a
+        with:
+          name: test-results
+          path: |
+            exercises/**/build/results.txt
+            exercises/**/build/results.json
+        if: failure()

.github/workflows/markdown.yml

@@ -17,6 +17,6 @@ jobs:
     name: Lint Markdown files
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
       - name: Lint markdown
-        uses: DavidAnson/markdownlint-cli2-action@992badcdf24e3b8eb7e87ff9287fe931bcb00c6e
+        uses: DavidAnson/markdownlint-cli2-action@6b51ade7a9e4a75a7ad929842dd298a3804ebe8b

CONTRIBUTING.md

@@ -209,7 +209,7 @@ Each problem/submodule has three source sets:
 
 ### Update/sync Gradle versions
 
-Please read [How to Update Gradle](../reference/how-to-update-gradle.md)
+Please read [How to Update Gradle](reference/how-to-update-gradle.md)
 
 ## Contributing to Concept Exercises
 

POLICIES.md

@@ -24,7 +24,6 @@ Our policies are not set-in-stone. They represent directions chosen at a point i
 |                                      | [Ignore noninitial tests](#ignore-noninitial-tests)                                                                                 |
 |                                      | [Multiple file submissions](#multiple-file-submissions)                                                                             |
 |                                      | [Name test class after class under test](#name-test-class-after-class-under-test)                                                   |
-|                                      | [Add hint for the first exercises without starter implementation](#add-hint-for-the-first-exercises-without-starter-implementation) |
 |                                      | [Reference tutorial in the first exercises](#reference-tutorial-in-the-first-exercises)                                             |
 |                                      | [Avoid returning null](#avoid-returning-null)                                                                                       |
 |                                      | [Prefer AssertJ assertions](#prefer-assertj-assertions)                                                                             |
@@ -44,16 +43,14 @@ References: [[1](https://github.com/exercism/java/issues/177#issuecomment-261291
 
 ### Starter implementations
 
-> - Exercises of difficulty 4 or lower: provide stubs for all required constructors and methods. This means that you need to provide stubs for those constructors or methods that are necessary to pass all tests. E.g. stubs for private methods may be skipped.
->   Stubs should include the following body:
+> Provide stubs for all required constructors and methods. This means that you need to provide stubs for those constructors or methods that are necessary to pass all tests. E.g. stubs for private methods may be skipped.
+> Stubs should include the following body:
 >
->   ```java
->   throw new UnsupportedOperationException("Delete this statement and write your own implementation.");
->   ```
->
-> - Exercises of difficulty 5 or higher: copy the StubTemplate.java file (provided in [this template file](https://github.com/exercism/java/blob/main/resources/exercise-template/src/main/java/ExerciseName.java)) and rename it to fit the exercise. For example, for the exercise linked-list the file could be named LinkedList.java. Then either (1) add hints to the hints.md file (which gets merged into the README.md for the exercise) or (2) provide stubs as above for exercises that demand complicated method signatures.
+> ```java
+> throw new UnsupportedOperationException("Delete this statement and write your own implementation.");
+> ```
 
-References: [[1](https://github.com/exercism/java/issues/178)], [[2](https://github.com/exercism/java/pull/683#discussion_r125506930)], [[3](https://github.com/exercism/java/issues/977)], [[4](https://github.com/exercism/java/issues/1721)]
+Reference: [[1](https://github.com/exercism/java/issues/2133)]
 
 ### Avoid using final
 
@@ -126,27 +123,14 @@ References: [[1](https://github.com/exercism/java/issues/395#issue-215734887)]
 
 References: [[1](https://github.com/exercism/java/issues/697)]
 
-### Add hint for the first exercises without starter implementation
-
-> According to the starter implementation policy, any exercise with difficulty 4 or lower should have starter implementation.
-> Any exercise with difficulty 5 or above will have no starter implementation (unless its signature is very complicated).
-> This could be confusing to users when tackling their first exercise with difficulty 5 when they are used to starter implementation being provided.
->
-> Therefore a hints.md file should be added to the .meta directory for every exercise with difficulty 5.
-> This file should explain what they need to do when there is no starter implementation.
-> The files should all be the same so you can copy it from any other exercise with difficulty 5, e.g. [flatten-array](https://github.com/exercism/java/tree/main/exercises/pratice/flatten-array/.meta/hints.md).
->
-> We add the file to every exercise with difficulty 5 because the structure of the track means that we don't know which exercise will be the first one without starter implementation that a user will be faced with.
-
-References: [[1](https://github.com/exercism/java/issues/1075)]
-
 ### Reference tutorial in the first exercises
 
 > The hello world exercise has an extensive tutorial on how to solve exercism exercises.
 > This tutorial would probably be useful to have as a reference when solving some of the other earlier exercises as well.
-> Therefore any exercise with difficulty less than 3 should have a hints.md file which references [the hello world tutorial](https://github.com/exercism/java/blob/main/exercises/practice/hello-world/.docs/instructions.append.md#tutorial).
+> Therefore any exercise with difficulty less than 3 should have a instructions.append.md file which references [the hello world tutorial](https://github.com/exercism/java/blob/main/exercises/practice/hello-world/.docs/instructions.append.md#tutorial).
 
 References: [[1](https://github.com/exercism/java/issues/1389)]
+Note: The PRs in the referenced issue uses hints.md, but this is now instructions.append.md (see [commit 52617354](https://github.com/exercism/java/commit/5261735435192b5b10535b2fcf41c81b638e5de5))
 
 ### Avoid returning null
 

bin/test-changed-exercise

@@ -0,0 +1,78 @@
+#!/usr/bin/env bash
+set -eo pipefail
+
+# Determine the base branch of the PR
+BASE_BRANCH=${GITHUB_BASE_REF:-main}
+
+# Fetch full history for proper diff
+git fetch origin "$BASE_BRANCH"
+
+# Compute merge base
+MERGE_BASE=$(git merge-base HEAD origin/"$BASE_BRANCH")
+
+# Get changed files relative to merge base
+changed_files=$(git diff --name-only "$MERGE_BASE" HEAD)
+
+# If any Gradle build file changed, run the full suite and exit
+if echo "$changed_files" | grep -qE '\.(gradle|gradlew|bat)$|settings\.gradle'; then
+  echo "Gradle build files changed, running full test suite..."
+  ./bin/test-with-test-runner
+  exit 0
+fi
+
+# Extract unique exercise directories
+changed_exercises=$(echo "$changed_files" | \
+  grep -E '^exercises/(practice|concept)/[^/]+/.+\.java$' | \
+  cut -d/ -f1-3 | sort -u)
+
+if [ -z "$changed_exercises" ]; then
+  echo "No relevant exercises changed, skipping tests."
+  exit 0
+fi
+
+# Print exercises
+echo "Changed exercises detected:"
+echo "$changed_exercises"
+echo "----------------------------------------"
+
+summary_dir="exercises/build"
+summary_file="${summary_dir}/summary.txt"
+mkdir -p "$summary_dir"
+
+# Run tests
+exit_code=0
+for dir in $changed_exercises; do
+  slug=$(basename "$dir")
+
+  echo "========================================"
+  echo "=== Running tests for $slug ==="
+  echo "========================================"
+
+  results_path="$dir/build/results.txt"
+  mkdir -p "$(dirname "$results_path")"
+
+  if [[ $dir == exercises/practice/* ]]; then
+    ./exercises/gradlew -p exercises ":practice:$slug:test" 2>&1 | tee "$results_path" || true
+  elif [[ $dir == exercises/concept/* ]]; then
+    ./exercises/gradlew -p exercises ":concept:$slug:test" 2>&1 | tee "$results_path" || true
+  fi
+
+  # Detect failure
+  if grep -q "FAILED" "$results_path"; then
+    exit_code=1
+
+    # Determine practice/slug or concept/slug
+    relative_path=$(echo "$dir" | sed 's|^exercises/||')
+
+    # Create summary.txt with header only on first failure
+    if [ ! -f "$summary_file" ]; then
+        echo "The following exercises have test failures or test errors:" > "$summary_file"
+    fi
+
+    # Append the correct path (practice/slug or concept/slug)
+    echo "$relative_path" >> "$summary_file"
+  fi
+
+done
+
+exit $exit_code

bin/test-deprecated-exercises

@@ -0,0 +1,42 @@
+#!/usr/bin/env bash
+set -eo pipefail
+
+# Determine the base branch of the PR
+BASE_BRANCH=${GITHUB_BASE_REF:-main}
+
+# Fetch full history for proper diff
+git fetch origin "$BASE_BRANCH"
+
+# Compute merge base
+MERGE_BASE=$(git merge-base HEAD origin/"$BASE_BRANCH")
+
+# Get changed files relative to merge base
+changed_files=$(git diff --name-only "$MERGE_BASE" HEAD)
+
+# Extract unique exercise directories
+changed_exercises=$(echo "$changed_files" | grep -E '^exercises/(practice|concept)/' || true)
+changed_exercises=$(echo "$changed_exercises" | cut -d/ -f1-3 | sort -u)
+
+# Early exit if no exercise changed
+if [ -z "$changed_exercises" ]; then
+  echo "No exercises changed!"
+  exit 0
+fi
+
+# Load deprecated exercises from config.json
+deprecated_exercises=$(jq -r '
+  [ 
+    (.exercises.concept[]? | select(.status=="deprecated") | "exercises/concept/" + .slug),
+    (.exercises.practice[]? | select(.status=="deprecated") | "exercises/practice/" + .slug)
+  ] | .[]
+' config.json)
+
+# Check for deprecated ones
+for ex in $changed_exercises; do
+  if echo "$deprecated_exercises" | grep -qx "$ex"; then
+    echo "❌ Deprecated exercise changed: $ex"
+    exit 1
+  fi
+done
+
+echo "✅ No deprecated exercises changed!"

bin/test-with-test-runner

@@ -12,6 +12,10 @@ docker pull exercism/java-test-runner
 
 exit_code=0
 
+summary_dir="exercises/build"
+summary_file="${summary_dir}/summary.txt"
+mkdir -p "$summary_dir"
+
 function run_test_runner() {
     local slug=$1
     local solution_dir=$2
@@ -56,6 +60,18 @@ function verify_exercise() {
 
     if [[ $(jq -r '.status' "${results_file}") != "pass" ]]; then
         echo "${slug}: ${implementation_file_key} solution did not pass the tests"
+
+        # Determine practice/slug or concept/slug
+        local relative_path=$(echo "$dir" | sed -E 's|.*/exercises/||')
+
+        # Create summary.txt with header only on first failure
+        if [ ! -f "$summary_file" ]; then
+            echo "The following exercises have test failures or test errors:" > "$summary_file"
+        fi
+
+        # Append the correct path (practice/slug or concept/slug)
+        echo "$relative_path" >> "$summary_file"
+
         exit_code=1
     fi
 

concepts/chars/.meta/config.json

@@ -3,5 +3,7 @@
   "authors": [
     "ystromm"
   ],
-  "contributors": []
+  "contributors": [
+    "kahgoh"
+  ]
 }