Update tag template format (#43)

Change `--noTemplates` output to use `%{tag}` for tagged template variables, instead of `%<tag>s`.

Author: SleeplessByte

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.2.1
+
+- Change `--noTemplates` output to use `%{tag}` for tagged template variables,
+  instead of `%<tag>s`.
+
 ## 0.2.0
 
 - Per https://github.com/exercism/automated-mentoring-support/issues/53,

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@exercism/javascript-analyzer",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "Exercism analyzer for javascript",
   "repository": "https://github.com/exercism/javascript-analyzer",
   "author": "Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>",

src/comments/comment.ts

@@ -104,7 +104,7 @@ export function factory<R extends string = ''>(strings: TemplateStringsArray, ..
 function buildTemplateTag(tag: string | number): string {
   return typeof tag === 'number'
     ? `%${tag}$s`
-    : `%<${tag}>s`
+    : `%{${tag}}`
 }
 
 function separateValues<R extends string>(...values: FactoryResultParameter<R>): { dictionary: NamedTags<R>; positionalValues: string[] } {

test/analyzers/two-fer/__snapshots__/snapshot.ts.snap

@@ -59,7 +59,7 @@ AnalyzerOutput {
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },
@@ -79,7 +79,7 @@ AnalyzerOutput {
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },
@@ -95,7 +95,7 @@ AnalyzerOutput {
     CommentImpl {
       "externalTemplate": "javascript.general.no_method",
       "message": "No method called \`twoFer\`. The tests won't pass without it.",
-      "template": "No method called \`%<method.name>s\`. The tests won't pass without it.",
+      "template": "No method called \`%{method.name}\`. The tests won't pass without it.",
       "variables": Object {
         "method.name": "twoFer",
       },
@@ -106,10 +106,10 @@ AnalyzerOutput {
 The tests won't pass without it.
 
 Did you forget adding: \`export twoFer\`?",
-      "template": "No [export](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/export) called \`%<export.name>s\`.
+      "template": "No [export](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/export) called \`%{export.name}\`.
 The tests won't pass without it.
 
-Did you forget adding: \`export %<export.name>s\`?",
+Did you forget adding: \`export %{export.name}\`?",
       "variables": Object {
         "export.name": "twoFer",
       },
@@ -129,7 +129,7 @@ AnalyzerOutput {
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },
@@ -149,7 +149,7 @@ AnalyzerOutput {
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },
@@ -189,7 +189,7 @@ that's not the case in this exercise.",
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },
@@ -229,7 +229,7 @@ that's not the case in this exercise.",
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },
@@ -249,7 +249,7 @@ AnalyzerOutput {
 of X to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "X",
       },
@@ -264,11 +264,11 @@ AnalyzerOutput {
   "comments": Array [
     CommentImpl {
       "externalTemplate": "javascript.two-fer.optimise_explicity_default_value",
-      "message": "Instead of relying on %<maybe_undefined_expression>s being \\"undefined\\" when
+      "message": "Instead of relying on %{maybe_undefined_expression} being \\"undefined\\" when
 no value is passed in, you could set the default value of 'name' to
 'you'.",
-      "template": "Instead of relying on %<maybe_undefined_expression>s being \\"undefined\\" when
-no value is passed in, you could set the default value of '%<parameter>s' to
+      "template": "Instead of relying on %{maybe_undefined_expression} being \\"undefined\\" when
+no value is passed in, you could set the default value of '%{parameter}' to
 'you'.",
       "variables": Object {
         "maybe-undefined-expression": "name",
@@ -285,11 +285,11 @@ AnalyzerOutput {
   "comments": Array [
     CommentImpl {
       "externalTemplate": "javascript.two-fer.optimise_explicity_default_value",
-      "message": "Instead of relying on %<maybe_undefined_expression>s being \\"undefined\\" when
+      "message": "Instead of relying on %{maybe_undefined_expression} being \\"undefined\\" when
 no value is passed in, you could set the default value of 'name' to
 'you'.",
-      "template": "Instead of relying on %<maybe_undefined_expression>s being \\"undefined\\" when
-no value is passed in, you could set the default value of '%<parameter>s' to
+      "template": "Instead of relying on %{maybe_undefined_expression} being \\"undefined\\" when
+no value is passed in, you could set the default value of '%{parameter}' to
 'you'.",
       "variables": Object {
         "maybe-undefined-expression": "name",
@@ -311,7 +311,7 @@ AnalyzerOutput {
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },
@@ -351,7 +351,7 @@ that's not the case in this exercise.",
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },
@@ -371,7 +371,7 @@ AnalyzerOutput {
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },
@@ -387,7 +387,7 @@ AnalyzerOutput {
     CommentImpl {
       "externalTemplate": "javascript.general.no_method",
       "message": "No method called \`twoFer\`. The tests won't pass without it.",
-      "template": "No method called \`%<method.name>s\`. The tests won't pass without it.",
+      "template": "No method called \`%{method.name}\`. The tests won't pass without it.",
       "variables": Object {
         "method.name": "twoFer",
       },
@@ -398,10 +398,10 @@ AnalyzerOutput {
 The tests won't pass without it.
 
 Did you forget adding: \`export twoFer\`?",
-      "template": "No [export](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/export) called \`%<export.name>s\`.
+      "template": "No [export](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/export) called \`%{export.name}\`.
 The tests won't pass without it.
 
-Did you forget adding: \`export %<export.name>s\`?",
+Did you forget adding: \`export %{export.name}\`?",
       "variables": Object {
         "export.name": "twoFer",
       },
@@ -421,7 +421,7 @@ AnalyzerOutput {
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },
@@ -441,7 +441,7 @@ AnalyzerOutput {
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },
@@ -461,7 +461,7 @@ AnalyzerOutput {
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },
@@ -481,7 +481,7 @@ AnalyzerOutput {
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },
@@ -501,7 +501,7 @@ AnalyzerOutput {
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },
@@ -521,7 +521,7 @@ AnalyzerOutput {
 of name to 'you' to avoid this conditional.",
       "template": "You currently use a conditional to branch in case there is no value passed into
 \`twoFer\`. Instead you could set the [default value](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters)
-of %<parameter>s to 'you' to avoid this conditional.",
+of %{parameter} to 'you' to avoid this conditional.",
       "variables": Object {
         "parameter": "name",
       },