Fix the tests

Author: SleeplessByte

exercises/concept/recycling-robot/assembly-line.spec.js

@@ -142,10 +142,15 @@ describe('isObject', () => {
     expect(isObject(new ClassForTesting(1488, 'World!'))).toBe(true);
   });
 
+  test('returns true for arrays which are objects', () => {
+    expect(isObject([])).toBe(true);
+    expect(isObject([{}])).toBe(true);
+  });
+
   test('returns false on functions', () => {
-    expect(isObject(isObject)).toBe(true);
-    expect(isObject(() => {})).toBe(true);
-    expect(isObject(() => ({}))).toBe(true);
+    expect(isObject(isObject)).toBe(false);
+    expect(isObject(() => {})).toBe(false);
+    expect(isObject(() => ({}))).toBe(false);
   });
 
   test('returns false for strings', () => {
@@ -168,12 +173,6 @@ describe('isObject', () => {
     expect(isObject(Symbol('1'))).toBe(false);
     expect(isObject(Symbol('true'))).toBe(false);
   });
-
-  test('returns false for arrays', () => {
-    expect(isObject([])).toBe(false);
-    expect(isObject([{}])).toBe(false);
-  });
-
   test('returns false for booleans', () => {
     expect(isObject(true)).toBe(false);
     expect(isObject(false)).toBe(false);
@@ -308,8 +307,8 @@ describe('isNonEmptyArray', () => {
     expect(isNonEmptyArray([1, 2, 3])).toBe(true);
     expect(isNonEmptyArray(['a', 'b'])).toBe(true);
 
-    // The prototype of Array is also an array
-    expect(isNonEmptyArray(Array.prototype)).toBe(true);
+    // The prototype of Array is also an array, but in Node it's considered empty
+    // expect(isNonEmptyArray(Array.prototype)).toBe(true);
   });
 
   test('returns false for empty arrays', () => {
@@ -352,15 +351,15 @@ describe('isNonEmptyArray', () => {
 
 describe('isEmptyArray', () => {
   test('returns true for empty arrays', () => {
-    expect(isEmptyArray([])).toBe(false);
+    expect(isEmptyArray([])).toBe(true);
   });
 
   test('returns false for non-empty arrays', () => {
     expect(isEmptyArray([1, 2, 3])).toBe(false);
     expect(isEmptyArray(['a', 'b'])).toBe(false);
 
-    // The prototype of Array is also an array
-    expect(isEmptyArray(Array.prototype)).toBe(false);
+    // The prototype of Array is also an array, but in Node it's considered empty
+    // expect(isEmptyArray(Array.prototype)).toBe(false);
   });
 
   test('returns false on fake empty arrays', () => {
@@ -493,11 +492,11 @@ describe('hasIdProperty', () => {
 
   test('returns false if it does not have the id property', () => {
     expect(hasIdProperty(new MethodData())).toBe(false);
-    expect(hasIdProperty({ color: 'green' })).toBe(true);
+    expect(hasIdProperty({ color: 'green' })).toBe(false);
   });
 
-  test('returns false if it inherited the id property', () => {
-    expect(hasIdProperty(new StealingData())).toBe(false);
+  test('returns true if the id property was set in the constructor in the prototype chain', () => {
+    expect(hasIdProperty(new StealingData())).toBe(true);
   });
 });