Skip to content

Commit e6dfcc9

Browse files
committed
Merge branch 'implement-error-handling-exercise' of https://github.com/A-O-Emmanuel/javascript into implement-error-handling-exercise
Updating local branch
2 parents a11995c + e673a32 commit e6dfcc9

292 files changed

Lines changed: 6353 additions & 4070 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/action-format.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
steps:
1414
- name: 'Post acknowledgement that it will format code'
1515
continue-on-error: true # Never fail the build if this fails
16-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea
16+
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3
1717
with:
1818
github-token: ${{ secrets.GITHUB_TOKEN }}
1919
script: |
@@ -65,7 +65,7 @@ jobs:
6565
run: corepack enable pnpm
6666

6767
- name: Use Node.js LTS (22.x)
68-
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020
68+
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e
6969
with:
7070
node-version: 22.x
7171
cache: 'pnpm'
@@ -95,7 +95,7 @@ jobs:
9595
9696
- name: 'Post acknowledgement that it has formatted the code'
9797
continue-on-error: true # Never fail the build if this fails
98-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea
98+
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3
9999
with:
100100
github-token: ${{ secrets.GITHUB_TOKEN }}
101101
script: |
@@ -109,7 +109,7 @@ jobs:
109109
- name: 'Post reminder to trigger build manually'
110110
continue-on-error: true # Never fail the build if this fails
111111
if: steps.fork_status.outputs.fork == 'true'
112-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea
112+
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3
113113
with:
114114
github-token: ${{ secrets.GITHUB_TOKEN }}
115115
script: |

.github/workflows/action-sync.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
steps:
1414
- name: 'Post acknowledgement that it will sync exercises'
1515
continue-on-error: true # Never fail the build if this fails
16-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea
16+
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3
1717
with:
1818
github-token: ${{ secrets.GITHUB_TOKEN }}
1919
script: |
@@ -87,7 +87,7 @@ jobs:
8787
8888
- name: 'Post acknowledgement that it has synced the code'
8989
continue-on-error: true # Never fail the build if this fails
90-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea
90+
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3
9191
with:
9292
github-token: ${{ secrets.GITHUB_TOKEN }}
9393
script: |
@@ -101,7 +101,7 @@ jobs:
101101
- name: 'Post reminder to trigger build manually'
102102
continue-on-error: true # Never fail the build if this fails
103103
if: steps.fork_status.outputs.fork == 'true'
104-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea
104+
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3
105105
with:
106106
github-token: ${{ secrets.GITHUB_TOKEN }}
107107
script: |

.github/workflows/ci.js.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ jobs:
1313
runs-on: ubuntu-24.04
1414

1515
steps:
16-
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
16+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
1717
- name: Enable corepack to fix https://github.com/actions/setup-node/pull/901
1818
run: corepack enable pnpm
1919

2020
- name: Use Node.js LTS (22.x)
21-
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020
21+
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e
2222
with:
2323
node-version: 22.x
2424
cache: 'pnpm'
@@ -37,12 +37,12 @@ jobs:
3737
node-version: [22.x]
3838

3939
steps:
40-
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
40+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
4141
- name: Enable corepack to fix https://github.com/actions/setup-node/pull/901
4242
run: corepack enable pnpm
4343

4444
- name: Use Node.js ${{ matrix.node-version }}
45-
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020
45+
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e
4646
with:
4747
node-version: ${{ matrix.node-version }}
4848
cache: 'pnpm'

.github/workflows/codeql.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ jobs:
2929

3030
steps:
3131
- name: Checkout repository
32-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
32+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
3333

3434
# Initializes the CodeQL tools for scanning.
3535
- name: Initialize CodeQL
36-
uses: github/codeql-action/init@v3
36+
uses: github/codeql-action/init@v4
3737
with:
3838
languages: ${{ matrix.language }}
3939
# If you wish to specify custom queries, you can do so here or in a config file.
@@ -44,7 +44,7 @@ jobs:
4444
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
4545
# If this step fails, then you should remove it and run the build manually (see below)
4646
- name: Autobuild
47-
uses: github/codeql-action/autobuild@v3
47+
uses: github/codeql-action/autobuild@v4
4848

4949
# ℹ️ Command-line programs to run using the OS shell.
5050
# 📚 https://git.io/JvXDl
@@ -58,4 +58,4 @@ jobs:
5858
# make release
5959

6060
- name: Perform CodeQL Analysis
61-
uses: github/codeql-action/analyze@v3
61+
uses: github/codeql-action/analyze@v4

.github/workflows/pr.ci.js.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111

1212
steps:
1313
- name: Checkout PR
14-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
14+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
1515
with:
1616
fetch-depth: ${{ github.event_name == 'pull_request' && 2 || 0 }}
1717

@@ -28,7 +28,7 @@ jobs:
2828
run: corepack enable pnpm
2929

3030
- name: Use Node.js LTS (22.x)
31-
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020
31+
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e
3232
with:
3333
node-version: 22.x
3434
cache: 'pnpm'
@@ -48,7 +48,7 @@ jobs:
4848

4949
steps:
5050
- name: Checkout PR
51-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
51+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
5252
with:
5353
fetch-depth: ${{ github.event_name == 'pull_request' && 2 || 0 }}
5454

@@ -65,7 +65,7 @@ jobs:
6565
run: corepack enable pnpm
6666

6767
- name: Use Node.js ${{ matrix.node-version }}
68-
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020
68+
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e
6969
with:
7070
node-version: ${{ matrix.node-version }}
7171
cache: 'pnpm'

.github/workflows/verify-code-formatting.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
runs-on: ubuntu-24.04
1111
steps:
1212
- name: 'Checkout code'
13-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
13+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
1414

1515
- name: 'Verify formatting of all files'
1616
run: ./bin/check-formatting.sh

.prettierignore

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
/.github/labels.yml
2-
/.github/workflows/sync-labels.yml
3-
/.github/workflows/no-important-files-changed.yml
2+
3+
# Generated
44
exercises/**/README.md
5+
pnpm-lock.yaml
6+
57
!/README.md
68

79
# Originates from https://github.com/exercism/org-wide-files
@@ -19,4 +21,4 @@ config.json
1921

2022
# Originates from https://github.com/exercism/problem-specifications
2123
exercises/practice/**/.docs/instructions.md
22-
exercises/practice/**/.docs/introduction.md
24+
exercises/practice/**/.docs/introduction.md

CONTRIBUTING.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@ This is the JavaScript track, one of the many tracks on [exercism][web-exercism]
44
You can find this in the [`config.json`][file-config].
55
It's not uncommon that people discover incorrect implementations of certain tests, have a suggestion for a track-specific hint to aid the student on the _JavaScript specifics_, see optimisations in terms of the configurations of `jest`, `eslint` or other dependencies, report missing edge cases, factual errors, logical errors, and, implement exercises or develop new exercises.
66

7+
> [!CAUTION]
8+
>
9+
> Please see https://github.com/exercism/javascript/issues/2144.
10+
>
11+
> All contributions _MUST_ preceed by opening a topic on the forum.
12+
> This is for both new content and fixes/changes to old content.
13+
714
We welcome contributions of all sorts and sizes, from reporting issues to submitting patches, as well as joining the current [discussions 💬][issue-discussion].
815

916
> [!WARNING]
@@ -112,6 +119,9 @@ Don't worry! You're not alone in this.
112119

113120
There are always improvements possible on existing exercises.
114121

122+
> [!IMPORTANT]
123+
> If you are opening a PR, please ensure you are _on a branch in your fork_, or our automated tooling will not work as expected.
124+
115125
#### Improving the README.md
116126

117127
For _practice_ exercises, `README.md` is generated from a canonical source.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ It also has a list of tools you can use, of which the `test` tool is one of them
2121

2222
## Running the code quality tooling (linter)
2323

24-
This run `eslint` for all files that _require_ linting.
24+
This runs `eslint` for all files that _require_ linting.
2525

2626
```shell
2727
corepack pnpm node scripts/lint.mjs --fix

concepts/basics/introduction.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ In contrast to `let` and `var`, variables that are defined with `const` can only
2121
```javascript
2222
const MY_FIRST_CONSTANT = 10;
2323

24-
// Can not be re-assigned.
24+
// Cannot be re-assigned.
2525
MY_FIRST_CONSTANT = 20;
2626
// => TypeError: Assignment to constant variable.
2727
```

0 commit comments

Comments
 (0)