Make so the test file name is formated in snakecase by generator#1765
Merged
Conversation
kotp
requested changes
Jul 26, 2025
| end | ||
|
|
||
| def to_snake(str) | ||
| str.gsub(/([a-z\d])([A-Z])/, '\1_\2').tr("-", "_").downcase |
Member
There was a problem hiding this comment.
Why not...
Suggested change
| str.gsub(/([a-z\d])([A-Z])/, '\1_\2').tr("-", "_").downcase | |
| str.tr("-", "_").downcase |
Are there tests for this file?
| str.split(/[-_]/).map(&:capitalize).join | ||
| end | ||
|
|
||
| def to_snake(str) |
Member
There was a problem hiding this comment.
I see camel_case right above here, should this be snake_case instead?
Member
There was a problem hiding this comment.
Also I see underscore is very similar. And the tests file has not been update to reflect testing of this new public method.
Member
Author
There was a problem hiding this comment.
Didn't think about that method. Was quite tired when I made this commit, but good suggestion.
kotp
approved these changes
Jul 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.