Add templates for exercises batch 9#1792
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
| value_copy /= 1000 | ||
| index += 1 | ||
| end | ||
| "#{value_copy} #{LABELS[index]}" |
There was a problem hiding this comment.
Trying to understand why the example files are changed here...
I thought this was about templates, and example files are not generally given by the upstream.
There was a problem hiding this comment.
problem spec added tests which were not coverd by the original example.
There was a problem hiding this comment.
This should likely be a patch outside of this patch-set then.
Thanks for doing the work for the additional (breaking changes, I presume) functionality for the example.rb file though.
There was a problem hiding this comment.
Yeah likely, I could still split it if you like?
There was a problem hiding this comment.
That would be good, because if a revert were needed for one or the other, then they would not be both affected.
ec621c9 to
07f8d5b
Compare
07f8d5b to
8d999fb
Compare
|
Depends on: #1794 |
Includes: