Add test for Anagram exercise to cover equivalent code points#2105
Add test for Anagram exercise to cover equivalent code points#2105bmwant wants to merge 1 commit into
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
@exercism/maintainers-admin can you check this one as it would affect results of all previously submitted solutions. |
|
@bmwant this is very rude. The message from the bot clearly says you should open a post on the forum. Instead, you ping somebody specifically to take a look. So you want others to give you attention, but yourself don't even read instructions given to you for how to contribute. Do you even know who the group maintainers-admin is? It's exactly one person at the moment, and they shouldn't be bothered with stuff like this. You've made your change in the wrong place. These test cases are coming from the problem-specifications repo. But again, you should post on the forum to discuss your proposed test before opening a PR there. |
|
Hello, my apologies for handling things the wrong way. I read this guide and checked other PRs before opening mine, and I didn’t mean to be rude or to seek attention with my proposed change. I misunderstood the bot’s comment, which suggested that I should ping someone from the mentioned group if my change might affect others’ solutions. I really enjoy the platform and just wanted to contribute back. As an apology gesture, I’ve also made a donation to support the organization. Sorry for any inconvenience caused by my actions. |
Description
Anagram problem states that
at the same time allowing naive solution to pass all the test cases
This PR adds a test to specifically target unicode macron symbol
that belongs to the
āgrapheme and should not consider this code point applied to different letters as anagrams.