Skip to content

verify_exercises_in_docker: avoid version mismatch#2135

Merged
senekor merged 1 commit into
mainfrom
senekor/qxrswnrmzuwx
Apr 13, 2026
Merged

verify_exercises_in_docker: avoid version mismatch#2135
senekor merged 1 commit into
mainfrom
senekor/qxrswnrmzuwx

Conversation

@senekor

@senekor senekor commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

The versions are pinned in the test runner. Hopefully they are not too
outdated, but they can easily be a few patch versions behind. If the
solution directory contains a lock file, these requirements often won't
be satisfied in the test runner.

The versions are pinned in the test runner. Hopefully they are not too
outdated, but they can easily be a few patch versions behind. If the
solution directory contains a lock file, these requirements often won't
be satisfied in the test runner.
@senekor senekor force-pushed the senekor/qxrswnrmzuwx branch from 2c43260 to 81c0f42 Compare April 13, 2026 15:06
@senekor senekor requested a review from ellnix April 13, 2026 15:13

@ellnix ellnix left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine, but did a conflict like this ever happen? If there's a case, I can't think of it. If it's prophylactic, that's fine.

Nevermind, this was the wrong PR to see first 😄 I see the other ones now.

@senekor

senekor commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

It's a valid question, since the lock file might not be created in some (most?) workflows. I do sometimes have them lying around. For quick and dirty changes to exercises, I cd into the exercise directory, copy the example solution to lib.rs, make my changes, run cargo test, copy the changes back to the example solution, restore lib.rs. So, this did fix a real issue for me :)

@senekor senekor merged commit b15e18c into main Apr 13, 2026
10 checks passed
@senekor senekor deleted the senekor/qxrswnrmzuwx branch April 13, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants