add Red language#62
Conversation
|
I don't get why these lines are cut out: |
kotp
left a comment
kotp
left a comment
There was a problem hiding this comment.
It just looked like it was "off".
| x: 1 ; line comment 1 | ||
| x: 2 ;-- line comment 2 | ||
| x: 3 ;@@ line comment 3 |
There was a problem hiding this comment.
| x: 1 ; line comment 1 | |
| x: 2 ;-- line comment 2 | |
| x: 3 ;@@ line comment 3 | |
| x: 1 ; line comment 1 | |
| x: 2 ;-- line comment 2 | |
| x: 3 ;@@ line comment 3 |
There was a problem hiding this comment.
it's intentional, but perhaps hard to deal with for the extractor. should it be seen as an extractor bug instead?
There was a problem hiding this comment.
First line should be left anyway, but it's not. It's not "off".
There was a problem hiding this comment.
Oh, of course it is, inside a herdoc string. Sorry about that. I did not look closely enough to get the context.
|
@loziniak Let me know when you are happy for this to be merged (CI is failing right now) |
|
It seems I found a bug in extractor - #63 , so perhaps it's better to wait until this PR can be tested by CI. |
|
Looking at the issues |
|
Ok, I just replied to both of them. We can continue the discussion there and keep iterating together :) |
4 participants
Added a test case similar to the one added to tokei. It includes comments inside strings, but probably that's not supported, so I'll probably delete this after checking what CI says.