Only dehydrate successful queries to prevent unhandled rejections (#8608)

The custom shouldDehydrateQuery callback was overriding TanStack Query's
default status check, allowing pending queries to be dehydrated. When a
pending query's promise later rejected (e.g. network error), the
dehydration catch handler would create an unhandled Error("redacted"),
which Sentry captured.

Add query.state.status === 'success' check to match the default behavior.

Closes #8605

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: iHiD

app/javascript/packs/application.tsx

@@ -249,8 +249,13 @@ if (typeof window !== 'undefined') {
       shouldDehydrateQuery: (query) => {
         const [key] = query.queryKey
         // only persist notifications and reputation in localStorage cache
-        return [NOTIFICATIONS_CACHE_KEY, REPUTATION_CACHE_KEY].includes(
-          key as string
+        // also check status to avoid dehydrating pending queries whose
+        // promises can reject with an unhandled "redacted" error
+        return (
+          query.state.status === 'success' &&
+          [NOTIFICATIONS_CACHE_KEY, REPUTATION_CACHE_KEY].includes(
+            key as string
+          )
         )
       },
     },