From a9014c2940d1c6caf274517e9ad3f5949cb6d534 Mon Sep 17 00:00:00 2001 From: dem4ron Date: Mon, 9 Feb 2026 11:15:11 +0100 Subject: [PATCH 1/2] Fix welcome modal width --- Gemfile.lock | 1 + .../components/modals/welcome-modal/WelcomeModal.tsx | 8 +++++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 4934ba5a1e..17d3bed23c 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -657,6 +657,7 @@ GEM PLATFORMS arm64-darwin-23 + arm64-darwin-24 x64-mingw32 x86_64-linux diff --git a/app/javascript/components/modals/welcome-modal/WelcomeModal.tsx b/app/javascript/components/modals/welcome-modal/WelcomeModal.tsx index 3c45cff30d..6415b15b45 100644 --- a/app/javascript/components/modals/welcome-modal/WelcomeModal.tsx +++ b/app/javascript/components/modals/welcome-modal/WelcomeModal.tsx @@ -134,9 +134,11 @@ export default function WelcomeModal({ null} className="m-welcome" From 49ca0aaa910114bc753f7c66d736f16d540900b0 Mon Sep 17 00:00:00 2001 From: dem4ron Date: Mon, 9 Feb 2026 11:42:35 +0100 Subject: [PATCH 2/2] Use correct modal --- .../BootcampAdvertismentView.tsx | 25 ++++++++++++++----- .../SenioritySurveyModal.tsx | 11 ++++++-- .../modals/welcome-modal/WelcomeModal.tsx | 19 +++++++++++--- 3 files changed, 43 insertions(+), 12 deletions(-) diff --git a/app/javascript/components/modals/seniority-survey-modal/BootcampAdvertismentView.tsx b/app/javascript/components/modals/seniority-survey-modal/BootcampAdvertismentView.tsx index 860637f5a1..c7f1381628 100644 --- a/app/javascript/components/modals/seniority-survey-modal/BootcampAdvertismentView.tsx +++ b/app/javascript/components/modals/seniority-survey-modal/BootcampAdvertismentView.tsx @@ -1,15 +1,28 @@ -import React, { useContext } from 'react' -import { GraphicalIcon, Icon } from '@/components/common' +import React from 'react' +import { Icon } from '@/components/common' import { FormButton } from '@/components/common/FormButton' import { ErrorBoundary, ErrorMessage } from '@/components/ErrorBoundary' -import { SenioritySurveyModalContext } from './SenioritySurveyModal' import { useAppTranslation } from '@/i18n/useAppTranslation' import { Trans } from 'react-i18next' +import { MutationStatus } from '@tanstack/react-query' const DEFAULT_ERROR = new Error('Unable to dismiss modal') -export function BootcampAdvertismentView() { - const { patchCloseModal, links } = useContext(SenioritySurveyModalContext) +type BootcampAdvertismentViewProps = { + patchCloseModal: { + mutate: () => void + status: string + error: unknown + } + links: { + codingFundamentalsCourse: string + } +} + +export function BootcampAdvertismentView({ + patchCloseModal, + links, +}: BootcampAdvertismentViewProps) { const { t } = useAppTranslation('components/modals/seniority-survey-modal') return ( @@ -86,7 +99,7 @@ export function BootcampAdvertismentView() { {t('bootcampAd.learnMore')} case 'bootcamp-advertisment': - return + return ( + + ) } } diff --git a/app/javascript/components/modals/welcome-modal/WelcomeModal.tsx b/app/javascript/components/modals/welcome-modal/WelcomeModal.tsx index 6415b15b45..f306b40b80 100644 --- a/app/javascript/components/modals/welcome-modal/WelcomeModal.tsx +++ b/app/javascript/components/modals/welcome-modal/WelcomeModal.tsx @@ -4,7 +4,7 @@ import { sendRequest } from '@/utils/send-request' import { Modal, ModalProps } from '../Modal' import { InitialView } from './InitialView' import { SeniorView } from './DeveloperView' -import { JuniorView } from './JuniorView' +import { BootcampAdvertismentView } from '../seniority-survey-modal/BootcampAdvertismentView' type ViewVariant = 'initial' | 'beginner' | 'developer' @@ -136,7 +136,12 @@ export default function WelcomeModal({ open={open} style={{ content: { - maxWidth: currentView === 'initial' ? '590px' : '1180px', + maxWidth: + currentView === 'initial' + ? '590px' + : currentView === 'beginner' + ? '620px' + : '1180px', }, }} {...props} @@ -150,12 +155,18 @@ export default function WelcomeModal({ } function Inner() { - const { currentView } = useContext(WelcomeModalContext) + const { currentView, patchCloseModal, links } = + useContext(WelcomeModalContext) switch (currentView) { case 'initial': return case 'beginner': - return + return ( + + ) case 'developer': return default: