Conversation
Use .scrub before .blank? to sanitize strings from external tooling services that may contain invalid UTF-8 byte sequences. This prevents BLANK_RE regex from raising ArgumentError when matching against them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When the JSON key doesn't exist in execution_output, the value is nil. Calling .scrub on nil raises NoMethodError. Using &.scrub allows nil to fall through to .blank? which correctly returns true for nil. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8466
Summary
.scrubbefore.blank?on strings from external tooling services (test runners, analyzers, representers) to preventArgumentError: invalid byte sequence in UTF-8when the data contains invalid UTF-8 bytesSubmission::TestRun::Process,Submission::Analysis::Process, andSubmission::Representation::ProcessTest plan
bundle exec rails test test/commands/submission/test_run/process_test.rb— 18 tests pass, 0 failuresArgumentError🤖 Generated with Claude Code