Conversation
Large custom amounts (e.g. 10 quintillion) caused currency.js intValue to produce 1e+21 in scientific notation, which Stripe rejects. Add max validation in CustomAmountInput (client-side) and PaymentIntentsController (server-side) capped at Stripe's $999,999.99 limit. Closes #8484 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8484
Summary
$999,999.99) toCustomAmountInput— both as an HTMLmaxattribute and a JavaScript check in the change handler. Values exceeding the max are treated as NaN, which all parent components already handle gracefully by falling back to defaults.PaymentIntentsController#createbefore calling the Stripe API, returning an error in the existing format.The root cause was that extremely large custom amounts (e.g.
10000000000000000000) get multiplied by 100 viacurrency.jsintValue, producing1e+21in JavaScript scientific notation, which Stripe Elements rejects.Test plan
bundle exec rails test test/controllers/api/payments/payment_intents_controller_test.rb— 8 tests, 0 failures🤖 Generated with Claude Code