Conversation
The existing network error filter catches Chrome's "Failed to fetch" and Firefox's "NetworkError when attempting to fetch resource" but misses Safari's equivalent "Load failed" message. These are non-actionable network errors that should not be reported. Closes #8584 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8584
Summary
TypeError), which is the equivalent of Chrome's "Failed to fetch" and Firefox's "NetworkError when attempting to fetch resource"beforeSendfilter already drops the Chrome and Firefox variants but was missing Safari's message"Load failed"to the network error filter so these non-actionable errors are no longer reportedTest plan
yarn test— all 1550 JS tests pass🤖 Generated with Claude Code