Conversation
Browsers with strict privacy settings (Safari private browsing, restricted iframes, cookie-blocked contexts) throw a SecurityError when accessing window.localStorage. This adds a safeLocalStorage() helper that returns null when access is denied, wraps the four unprotected call sites, and adds a Sentry beforeSend filter to suppress the non-actionable error. Closes #8595 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8595
Summary
safeLocalStorage()helper that wrapswindow.localStoragein a try/catch and returnsnullwhen access is denied (Safari private browsing, restricted iframes, strict cookie settings)application.tsx— the library already acceptsnulland returns a no-op persister, so the app gracefully skips cache persistenceapplication.tsx— if storage is inaccessible, there's nothing to clearlocalStorage.getItem()calls inNewListItemForm.tsxandStartDiscussionPanel.tsxwith try/catch, falling back to empty stringbeforeSendfilter to suppress the non-actionableSecurityErrorfor localStorage/sessionStorage access, following the existing pattern for other browser-specific errorsTest plan
yarn testpasses (1550 tests passed)createSyncStoragePersistergracefully handlesnullstorage (returns no-op persister)🤖 Generated with Claude Code