Skip to content

Guard against Array status in test results #8637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iHiD merged 1 commit into from
Feb 13, 2026
Merged

Guard against Array status in test results #8637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/submission/test_run.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class TestResult
def to_h
{
name: test[:name].to_s,
status: test[:status].try(&:to_sym),
status: Array(test[:status]).first.try(&:to_sym),
test_code: test[:test_code],
message: test[:message],
message_html: Ansi::RenderHTML.(test[:message]),
Expand Down
6 changes: 6 additions & 0 deletions test/models/submission/test_run_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,12 @@ class Submission::TestRunTest < ActiveSupport::TestCase
assert_equal 3, tr.version
end

test "handles test result status as array" do
tests = [{ 'name' => 'test1', 'status' => ['pass'] }]
tr = create(:submission_test_run, raw_results: { version: 2, status: 'pass', tests: tests })
assert_equal :pass, tr.test_results.first.to_h[:status]
end

test "truncate message" do
message = 'a' * 66_000
test_run = create(:submission_test_run, raw_results: { message: })
Expand Down
Loading