Conversation
Add retry_on for Aws::Sigv4::Errors::MissingCredentialsError and Aws::Errors::MissingCredentialsError to ApplicationJob, so any job hitting a transient credential issue (e.g. during credential rotation or ECS task role refresh) retries up to 3 times with 10s wait. Persistent failures still raise to Sentry after retries exhaust. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8630
Closes #8636
Summary
retry_onforAws::Sigv4::Errors::MissingCredentialsErrorandAws::Errors::MissingCredentialsErrortoApplicationJobSubmission::File#raw_content(PR Add retry for transient AWS credential errors in Submission::File #8469) by covering all other S3 code paths (e.g.put_object, Active Storage)Test plan
Aws::Sigv4::Errors::MissingCredentialsErrorandAws::Errors::MissingCredentialsErrorretry behaviorapplication_job_test.rbtests pass (including 2 new)🤖 Generated with Claude Code