Conversation
When a non-JSON response (rate limit "Retry later", HTML error page, binary data) was thrown by fetchJSON, useErrorHandler unconditionally called .json() on it, producing a SyntaxError that was reported to Sentry. Now we check the Content-Type header first and only attempt JSON parsing when the response claims to be JSON. Closes #8633 Closes #8632 Closes #8628 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8633
Closes #8632
Closes #8628
Summary
fetchJSON,useErrorHandlerinErrorBoundary.tsxunconditionally called.json()on it, producing aSyntaxErrorthat was reported to SentryContent-Typeheader first and only attempts JSON parsing when the response claims to be JSON — mirrors the same check already used infetch-json.tsTest plan
yarn test— all 160 suites pass (1551 tests), no regressionsreact-i18next)🤖 Generated with Claude Code