From 553036cb47140898866f4d6ccc5b9fcc3aae0f79 Mon Sep 17 00:00:00 2001 From: Jeremy Walker Date: Wed, 15 Apr 2026 11:38:26 +0900 Subject: [PATCH] Remove admin guard from perk click logging Co-Authored-By: Claude Opus 4.6 (1M context) --- app/commands/partner/log_perk_click.rb | 8 -------- test/commands/partner/log_perk_click_test.rb | 10 ---------- 2 files changed, 18 deletions(-) diff --git a/app/commands/partner/log_perk_click.rb b/app/commands/partner/log_perk_click.rb index c20f9a0e4e..4618a5b8ce 100644 --- a/app/commands/partner/log_perk_click.rb +++ b/app/commands/partner/log_perk_click.rb @@ -5,18 +5,10 @@ class LogPerkClick initialize_with :perk, :user, :clicked_at def call - return unless valid_click? - Perk.where(id: perk.id).update_all('num_clicks = num_clicks + 1') end private - def valid_click? - return false if user&.admin? - - true - end - def doc { perk_id: perk.id, diff --git a/test/commands/partner/log_perk_click_test.rb b/test/commands/partner/log_perk_click_test.rb index 7ee723836d..061df2b409 100644 --- a/test/commands/partner/log_perk_click_test.rb +++ b/test/commands/partner/log_perk_click_test.rb @@ -9,14 +9,4 @@ class Partner::LogPerkClickTest < ActiveSupport::TestCase assert_equal 1, perk.reload.num_clicks end - - test "doesn't log for admin users" do - perk = create :perk - user = create :user, :admin - assert_equal 0, perk.num_clicks - - Partner::LogPerkClick.(perk, user, nil) - - assert_equal 0, perk.reload.num_clicks - end end