Skip to content

Remove admin guard from perk click logging #9020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iHiD merged 1 commit into from
Apr 15, 2026
Merged

Remove admin guard from perk click logging #9020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions app/commands/partner/log_perk_click.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,10 @@ class LogPerkClick
initialize_with :perk, :user, :clicked_at

def call
return unless valid_click?

Perk.where(id: perk.id).update_all('num_clicks = num_clicks + 1')
end

private
def valid_click?
return false if user&.admin?

true
end

def doc
{
perk_id: perk.id,
Expand Down
10 changes: 0 additions & 10 deletions test/commands/partner/log_perk_click_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,4 @@ class Partner::LogPerkClickTest < ActiveSupport::TestCase

assert_equal 1, perk.reload.num_clicks
end

test "doesn't log for admin users" do
perk = create :perk
user = create :user, :admin
assert_equal 0, perk.num_clicks

Partner::LogPerkClick.(perk, user, nil)

assert_equal 0, perk.reload.num_clicks
end
end
Loading