Skip to content

Commit 35c6a2f

Browse files
committed
add screen size to the frontend dashboard
1 parent e03a8ac commit 35c6a2f

File tree

4 files changed

+10
-1
lines changed

4 files changed

+10
-1
lines changed

web/src/api/constants.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export const dimensionNames: Record<Dimension, string> = {
2424
utm_medium: "UTM Medium",
2525
utm_source: "UTM Source",
2626
utm_term: "UTM Term",
27+
screen_size: "Screen Size",
2728
};
2829

2930
export const filterNames: Record<DimensionFilter["filterType"], string> = {

web/src/api/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ export const dimensions = [
2525
"utm_medium",
2626
"utm_source",
2727
"utm_term",
28+
"screen_size",
2829
] as const satisfies Dimension[];
2930

3031
export const filterTypes = [

web/src/components/dimensions/index.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Tabs } from "@base-ui/react/tabs";
2-
import { LinkIcon, PinIcon, SquareArrowOutUpRightIcon } from "lucide-react";
2+
import { LinkIcon, MonitorIcon, PinIcon, SquareArrowOutUpRightIcon } from "lucide-react";
33
import styles from "./dimensions.module.css";
44

55
import { type Dimension, type DimensionTableRow, dimensionNames, metricNames, useDimension } from "../../api";
@@ -298,6 +298,12 @@ const dimensionLabels: Record<Dimension, (value: DimensionTableRow, onSelect: ()
298298
<DimensionValueButton onSelect={onSelect}>{value.dimensionValue}</DimensionValueButton>
299299
</>
300300
),
301+
screen_size: (value, onSelect) => (
302+
<>
303+
<MonitorIcon size={16} />
304+
<DimensionValueButton onSelect={onSelect}>{value.dimensionValue || "Unknown"}</DimensionValueButton>
305+
</>
306+
),
301307
};
302308

303309
const isValidFqdn = (fqdn: string) => {

web/src/components/project.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ export const Project = () => {
138138
<GeoCard query={query} onSelect={onSelectDimRow} />
139139
<DimensionTabsCard dimensions={["platform", "browser"]} query={query} onSelect={onSelectDimRow} />
140140
<DimensionCard dimension={"mobile"} query={query} onSelect={(v) => onSelectDimRow(v, "mobile")} />
141+
<DimensionCard dimension={"screen_size"} query={query} onSelect={(v) => onSelectDimRow(v, "screen_size")} />
141142
</div>
142143
</Suspense>
143144
</div>

0 commit comments

Comments
 (0)