Skip to content

Commit adf0384

Browse files
committed
add screen size to the dashboard
1 parent 1d47f92 commit adf0384

File tree

4 files changed

+10
-1
lines changed

4 files changed

+10
-1
lines changed

web/src/api/constants.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ export const dimensionNames: Record<Dimension, string> = {
2222
utm_medium: "UTM Medium",
2323
utm_source: "UTM Source",
2424
utm_term: "UTM Term",
25+
screen_resolution: "Screen Resolution",
2526
};
2627

2728
export const filterNames: Record<DimensionFilter["filterType"], string> = {

web/src/api/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ export const dimensions = [
2323
"utm_medium",
2424
"utm_source",
2525
"utm_term",
26+
"screen_resolution",
2627
] as const satisfies Dimension[];
2728

2829
export const filterTypes = [

web/src/components/dimensions/index.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Tabs } from "@base-ui/react/tabs";
2-
import { LinkIcon, PinIcon, SquareArrowOutUpRightIcon } from "lucide-react";
2+
import { LinkIcon, MonitorIcon, PinIcon, SquareArrowOutUpRightIcon } from "lucide-react";
33
import styles from "./dimensions.module.css";
44

55
import { type Dimension, type DimensionTableRow, dimensionNames, metricNames, useDimension } from "../../api";
@@ -290,6 +290,12 @@ const dimensionLabels: Record<Dimension, (value: DimensionTableRow, onSelect: ()
290290
<DimensionValueButton onSelect={onSelect}>{value.dimensionValue}</DimensionValueButton>
291291
</>
292292
),
293+
screen_resolution: (value, onSelect) => (
294+
<>
295+
<MonitorIcon size={16} />
296+
<DimensionValueButton onSelect={onSelect}>{value.dimensionValue || "Unknown"}</DimensionValueButton>
297+
</>
298+
),
293299
};
294300

295301
const isValidFqdn = (fqdn: string) => {

web/src/components/project.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ export const Project = () => {
121121
<GeoCard query={query} onSelect={onSelectDimRow} />
122122
<DimensionTabsCard dimensions={["platform", "browser"]} query={query} onSelect={onSelectDimRow} />
123123
<DimensionCard dimension={"mobile"} query={query} onSelect={(v) => onSelectDimRow(v, "mobile")} />
124+
<DimensionCard dimension={"screen_resolution"} query={query} onSelect={(v) => onSelectDimRow(v, "screen_resolution")} />
124125
</div>
125126
</Suspense>
126127
</div>

0 commit comments

Comments
 (0)