chore: retry duckdb init when file is locked, improve errors

Signed-off-by: Henry <mail@henrygressmann.de>

Author: explodingcamera

CHANGELOG.md

@@ -20,6 +20,7 @@ Since this is not a library, this changelog focuses on the changes that are rele
 
 - Updated to the latest version of DuckDB (1.5.1)
 - Fixed error when both `listen` and `port` configuration options are set
+- Added retry logic when loading the DuckDB database to handle potential locking issues on startup (e.g. when the database is being updated by another process or when using a shared network drive)
 
 ## [v1.4.0] - 2026-03-14
 

Cargo.lock

@@ -76,13 +76,13 @@ aide={version="0.16.0-alpha.3", default-features=false, features=[
     "axum-extra-headers",
 ]}
 schemars={version="1.2", features=["derive", "chrono04"]}
-
+url="2.5"
 ua-parser="0.2"
 rust-embed={version="8.11", features=["mime-guess"]}
 reqwest={version="0.13", default-features=false, features=["json", "stream", "charset", "rustls"]}
 
 # database
-duckdb={version="1.10501", features=["buildtime_bindgen", "chrono", "bundled", "r2d2"]}
+duckdb={version="1.10501", features=["chrono", "bundled", "r2d2"]}
 rusqlite={version="0.39", features=["bundled", "modern_sqlite", "chrono"]}
 r2d2={version="0.8", default-features=false}
 refinery={version="0.9", default-features=false}

Cargo.toml

@@ -1,8 +1,5 @@
-# The base URL of the Liwan instance
-base_url="http://localhost:9042"
-
-# The port to listen on (http)
-port=9042
+base_url="http://localhost:9042" # The base URL of the Liwan instance
+listen=9042 # The port to listen on (http)
 
 # # Folder to store the database in (Will be created if it doesn't exist)
 # # defaults to $HOME/.local/share/liwan/data on linux/macos

data/config.example.toml

@@ -3,7 +3,7 @@ use crate::utils::refinery_duckdb::DuckDBConnection;
 use crate::utils::refinery_sqlite::RqlConnection;
 
 use crate::utils::r2d2_sqlite::SqliteConnectionManager;
-use anyhow::{Result, bail};
+use anyhow::{Context, Result, bail};
 use duckdb::DuckdbConnectionManager;
 use refinery::Runner;
 use std::path::PathBuf;
@@ -13,24 +13,40 @@ pub(super) fn init_duckdb(
     duckdb_config: DuckdbConfig,
     mut migrations_runner: Runner,
 ) -> Result<r2d2::Pool<DuckdbConnectionManager>> {
-    let mut flags = duckdb::Config::default()
-        .enable_autoload_extension(true)?
-        .access_mode(duckdb::AccessMode::ReadWrite)?
-        .with("enable_fsst_vectors", "true")?
-        .with("allocator_background_threads", "true")?;
-
-    if let Some(memory_limit) = duckdb_config.memory_limit {
-        flags = flags.max_memory(&memory_limit)?;
-    }
+    let mut tries = 10;
+    let conn = loop {
+        let mut flags = duckdb::Config::default()
+            .enable_autoload_extension(true)?
+            .access_mode(duckdb::AccessMode::ReadWrite)?
+            .with("enable_fsst_vectors", "true")?
+            .with("allocator_background_threads", "true")?;
+
+        if let Some(memory_limit) = &duckdb_config.memory_limit {
+            flags = flags.max_memory(memory_limit)?;
+        }
 
-    if let Some(threads) = duckdb_config.threads {
-        flags = flags.threads(threads.get().into())?;
-    }
+        if let Some(threads) = duckdb_config.threads {
+            flags = flags.threads(threads.get().into())?;
+        }
 
-    let conn = DuckdbConnectionManager::file_with_flags(path, flags).map_err(|e| {
-        tracing::warn!("Failed to create DuckDB connection. If you've just upgraded to Liwan 1.2, please downgrade to version 1.1.1 first, start and stop the server, and then upgrade to 1.2 again.");
-        anyhow::anyhow!("Failed to create DuckDB connection: {}", e)
-    })?;
+        match DuckdbConnectionManager::file_with_flags(path, flags) {
+            Ok(conn) => break conn,
+            Err(e) => {
+                if tries <= 0 {
+                    tracing::warn!("");
+                    return Err(e).context("Failed to load DuckDB Database after 10 attempts");
+                }
+
+                if e.to_string().contains("Could not set lock on file") {
+                    tracing::warn!("DuckDB database is locked. Retrying... ({} tries left)", tries);
+                    tries -= 1;
+                    std::thread::sleep(std::time::Duration::from_secs(1));
+                } else {
+                    return Err(e).context("Failed to load DuckDB Database");
+                }
+            }
+        }
+    };
 
     let pool = r2d2::Pool::new(conn)?;
     {

data/licenses-cargo.json

@@ -1,11 +1,11 @@
 use anyhow::{Context, Result, bail};
 use figment::Figment;
 use figment::providers::{Env, Format, Toml};
-use http::Uri;
 use serde::{Deserialize, Serialize};
 use std::net::SocketAddr;
 use std::num::NonZeroU16;
 use std::str::FromStr;
+use url::Url;
 
 fn default_base() -> String {
     "http://localhost:9042".to_string()
@@ -162,12 +162,22 @@ impl Config {
             }))
             .extract()?;
 
-        let url: Uri = Uri::from_str(&config.base_url).context("Invalid base URL")?;
+        let url: Url = Url::from_str(&config.base_url).context("Invalid base URL")?;
 
-        if ![Some("http"), Some("https")].contains(&url.scheme_str()) {
+        if !["http", "https"].contains(&url.scheme()) {
             bail!("Invalid base URL: protocol must be either http or https");
         }
 
+        if url.scheme() != "https" {
+            tracing::warn!("Base URL is not using HTTPS");
+        }
+
+        if config.listen.is_some() && config.port.is_some() {
+            tracing::warn!(
+                "Both `listen` and `port` configuration options are set. The `listen` option will take precedence over `port`."
+            );
+        }
+
         Ok(config)
     }
 

data/licenses-npm.json

@@ -2,7 +2,7 @@ pub mod routes;
 pub mod session;
 pub mod webext;
 
-use std::net::SocketAddr;
+use std::net::{SocketAddr, ToSocketAddrs};
 use std::ops::Deref;
 use std::sync::{Arc, mpsc::Sender};
 
@@ -140,9 +140,13 @@ pub async fn start_webserver(app: Arc<Liwan>, events: Sender<Event>) -> Result<(
     #[cfg(debug_assertions)]
     save_spec(router.1)?;
 
-    let listener = tokio::net::TcpListener::bind(app.config.listen_addr())
+    let socket_addrs: Vec<_> =
+        app.config.listen_addr().to_socket_addrs().context("Failed to resolve listen address")?.collect();
+
+    let listener = tokio::net::TcpListener::bind(socket_addrs.as_slice())
         .await
         .with_context(|| format!("Failed to bind to address {}", app.config.listen_addr()))?;
+
     let service = router.0.into_make_service_with_connect_info::<SocketAddr>();
     axum::serve(listener, service).await.context("server exited unexpectedly")
 }