fix(tam#37340): rename the Selected column to Adoption

Its cells are 'Adopted' / 'Not Adopted', so a 'Selected' header (what PCA's older
variances_judged calls it) does not agree with its own values in the English
report. Japanese renders 採否 / 採用 / 非採用 either way.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: hidekoji

R/factanal.R

@@ -835,7 +835,10 @@ tidy.fa_exploratory <- function(x, type="loadings", n_sample=NULL, pretty.name=F
       `Cummulated % Variance` = cumsum(pct_variance),
       `Parallel Analysis` = parallel_label,
       `Kaiser Criterion` = ifelse(kaiser_adopted, "Adopted", "Not Adopted"),
-      Selected = ifelse(selected_adopted, "Adopted", "Not Adopted"),
+      # Column name "Adoption", not PCA's "Selected": the cells read "Adopted" / "Not Adopted", so a
+      # "Selected" header would not agree with its own values in the English report. Both map to
+      # 採否 / 採用 / 非採用 in Japanese. (tam#37340)
+      Adoption = ifelse(selected_adopted, "Adopted", "Not Adopted"),
       parallel_status = parallel_status,
       kaiser_status = ifelse(kaiser_adopted, "adopted", "not_adopted"),
       selected_status = ifelse(selected_adopted, "adopted", "not_adopted")

tests/testthat/test_factanal.R

@@ -360,7 +360,7 @@ test_that("report part 3: variances_judged, suitability P value format, analysis
   judged <- tidy(fit, type = "variances_judged")
   expect_equal(colnames(judged),
                c("Factor", "Eigenvalue", "% Variance", "Cummulated % Variance",
-                 "Parallel Analysis", "Kaiser Criterion", "Selected",
+                 "Parallel Analysis", "Kaiser Criterion", "Adoption",
                  "parallel_status", "kaiser_status", "selected_status"))
   n_var <- length(fit$communality)
   expect_equal(nrow(judged), n_var)
@@ -377,7 +377,7 @@ test_that("report part 3: variances_judged, suitability P value format, analysis
   expect_false(any(judged$kaiser_status == "na"))
   # Selected = the factors this analysis actually extracted (nfactors), first rows only.
   expect_equal(judged$selected_status, ifelse(seq_len(n_var) <= 2, "adopted", "not_adopted"))
-  expect_equal(judged$Selected, ifelse(seq_len(n_var) <= 2, "Adopted", "Not Adopted"))
+  expect_equal(judged$Adoption, ifelse(seq_len(n_var) <= 2, "Adopted", "Not Adopted"))
   # Labels stay English-canonical; the client translates them. "Adopted" (not PCA's "Adopt") so the
   # English report reads as a judgment against "Not Adopted".
   expect_true(all(judged$`Parallel Analysis` %in% c("Adopted", "Not Adopted", "Not Available")))