Commit 5a36abe
test(oracle): compare resolveOracleClientLocation home with separators neutralized
The Windows daily test failed on test_system.R:1287:
Expected 'resolved$home' to equal 'homeLayout'.
x[1]: "C:/Users/.../file18b41bfa68e1/client64"
y[1]: "C:\\Users\\...\\file18b41bfa68e1/client64"
Test-only bug, not a production one. On Windows tempfile() returns backslashes,
file.path() appends with a forward slash, so homeLayout is a MIXED-separator
string. resolveOracleClientLocation derives home via dirname(), and dirname()
on Windows rewrites every separator to a forward slash -- so the two strings
describe the same directory but can never be identical() there. Mac/Linux never
see it because tempfile() already returns forward slashes.
Compare with the separators neutralized instead (a no-op on Mac/Linux). The
assertion still pins that home is the parent of the lib directory -- the zip
layout's home == "" case and the libDir assertion are untouched.
Verified on the Windows daily-test box (exp-test1) against the installed
package: identical() is FALSE pre-fix and TRUE post-fix; full test_system.R
still passes on Mac ARM.
No DESCRIPTION bump: tests only, no shipped R code change, so no rebuilt
binaries are required.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent fe4e304 commit 5a36abe
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1282 | 1282 | | |
1283 | 1283 | | |
1284 | 1284 | | |
| 1285 | + | |
| 1286 | + | |
| 1287 | + | |
| 1288 | + | |
1285 | 1289 | | |
1286 | 1290 | | |
1287 | | - | |
| 1291 | + | |
1288 | 1292 | | |
1289 | 1293 | | |
1290 | 1294 | | |
| |||
0 commit comments