Skip to content

Commit 6386934

Browse files
kei51eclaude
andcommitted
fix(#36055): align prob_dist_prop and prob_dist_diff with sample code
- prob_dist_prop: clamp x to [0, 1] so proportion chart never shows out-of-range values when p0 is near 0 or 1 with small n - prob_dist_diff: use abs() for se_val to match sample code convention and tighten degenerate guard to se_val == 0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 3be911f commit 6386934

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

R/test_wrapper.R

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1311,8 +1311,8 @@ tidy.ttest_exploratory <- function(x, type="model", conf_level=0.95) {
13111311
est <- unname(x$estimate)
13121312
difference <- if (length(est) >= 2) est[1] - est[2] else est[1]
13131313
t_stat <- unname(x$statistic)
1314-
se_val <- if (!is.na(t_stat) && t_stat != 0) difference / t_stat else NA_real_
1315-
if (is.na(se_val) || se_val <= 0) {
1314+
se_val <- if (!is.na(t_stat) && t_stat != 0) abs(difference / t_stat) else NA_real_
1315+
if (is.na(se_val) || se_val == 0) {
13161316
ret <- tibble::tibble(x = numeric(0), y = numeric(0)) # degenerate input -> chart no-ops
13171317
} else {
13181318
ret <- generate_ttest_density_data(t = t_stat, p.value = x$p.value, df = unname(x$parameter),
@@ -3528,7 +3528,8 @@ tidy.one_sample_prop_test_exploratory <- function(x, type = "model") {
35283528
tibble::tibble(x = numeric(0), y = numeric(0)) # degenerate input -> chart no-ops
35293529
} else {
35303530
generate_norm_density_data(x$observed_prop, p.value = x$htest$p.value, mu = x$p, sigma = x$se,
3531-
sig_level = x$sig.level, alternative = x$alternative)
3531+
sig_level = x$sig.level, alternative = x$alternative) %>%
3532+
dplyr::filter(x >= 0 & x <= 1)
35323533
}
35333534
} else { # type == "data"
35343535
# Return the original data so that the data-level charts (Error Bar Plot,

0 commit comments

Comments
 (0)