fix(factanal): restore na.rm/quantile_prob/retained from spec's final compute_parallel_analysis() (#37332)

Independent spec-compliance verification pass found 3 elements present in
the issue's own "完成版" (finished) code for compute_parallel_analysis()
that were dropped during implementation:
- na.rm = TRUE on the random_threshold stats::quantile() call
- quantile_prob echoed back as a field on the returned list
- a retained boolean column on the returned table (seq_along(actual_eigen)
  <= recommended_n)

None change existing consumers (parallel_screeplot/factor_count only read
table$actual_eigenvalue/random_eigenvalue_threshold by name), so this is a
pure additive fix restoring exact spec fidelity. Updated the one pinned
colnames()/field assertion in test_factanal.R accordingly.

Author: hidekoji

R/factanal.R

@@ -299,7 +299,7 @@ compute_parallel_analysis <- function(x, n_iter = 100, quantile_prob = 0.95,
     return(NULL) # no usable null distribution; the caller reports the parallel analysis as unavailable
   }
   random_eigen_mat <- do.call(cbind, random_eigen_list)
-  random_threshold <- apply(random_eigen_mat, 1, stats::quantile, probs = quantile_prob)
+  random_threshold <- apply(random_eigen_mat, 1, stats::quantile, probs = quantile_prob, na.rm = TRUE)
   recommended_n <- compute_parallel_recommended_n(actual_eigen, random_threshold)
 
   list(
@@ -308,11 +308,13 @@ compute_parallel_analysis <- function(x, n_iter = 100, quantile_prob = 0.95,
     requested_n_iter = n_iter,
     successful_n_iter = length(random_eigen_list),
     failed_n_iter = n_iter - length(random_eigen_list),
+    quantile_prob = quantile_prob,
     recommended_n = recommended_n,
     table = tibble::tibble(
       factor_number = seq_along(actual_eigen),
       actual_eigenvalue = actual_eigen,
-      random_eigenvalue_threshold = random_threshold
+      random_eigenvalue_threshold = random_threshold,
+      retained = seq_along(actual_eigen) <= recommended_n
     )
   )
 }

tests/testthat/test_factanal.R

@@ -338,10 +338,12 @@ test_that("factor analysis report judgment helpers (issue #37018)", {
   set.seed(1)
   pa <- compute_parallel_analysis(mtcars[, c("mpg","cyl","disp","hp","drat","wt","qsec")], n_iter = 20)
   expect_true(is.numeric(pa$recommended_n))
-  expect_equal(colnames(pa$table), c("factor_number", "actual_eigenvalue", "random_eigenvalue_threshold"))
+  expect_equal(colnames(pa$table), c("factor_number", "actual_eigenvalue", "random_eigenvalue_threshold", "retained"))
   # method defaults to "factor_model" (issue tam#37332).
   expect_equal(pa$method, "factor_model")
   expect_equal(pa$factor_extraction_method, "minres")
+  expect_equal(pa$quantile_prob, 0.95)
+  expect_equal(pa$table$retained, seq_len(nrow(pa$table)) <= pa$recommended_n)
   set.seed(99)
   before <- .Random.seed
   compute_parallel_analysis(mtcars[, 1:3], n_iter = 2)