chore: team checks

Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>

Author: exploreriii

.github/scripts/lib/eligibility/has-eligibility-01-gfi.js

@@ -3,6 +3,8 @@
  * a Good First Issue (GFI) in this repository.
  *
  * ELIGIBILITY RULES:
+ * - Repository team members (triage / write / maintain / admin)
+ *   are always eligible and bypass all checks.
  * - Normal contributors may have up to `MAX_OPEN_ISSUES_NORMAL`
  *   open issue assignments.
  * - Contributors listed in the spam list may have up to
@@ -16,16 +18,16 @@
  * - It does NOT post comments.
  * - Callers must invoke this before attempting assignment.
  *
- *
  * @param {Object} params
  * @param {import('@actions/github').GitHub} params.github - Authenticated GitHub client
  * @param {string} params.owner - Repository owner
  * @param {string} params.repo - Repository name
  * @param {string} params.username - GitHub username to check
  * @returns {Promise<boolean>} Whether the contributor may be assigned a GFI
  */
-const { countOpenAssignedIssues } = require('..counts/count-open-assigned-issues');
+const { isTeam } = require('./is-team');
 const { isOnSpamList } = require('../counts/is-on-spam-list');
+const { countOpenAssignedIssues } = require('../counts/count-open-assigned-issues');
 
 const MAX_OPEN_ISSUES_NORMAL = 2;
 const MAX_OPEN_ISSUES_SPAM_LIST = 1;
@@ -43,6 +45,14 @@ const hasGfiEligibility = async ({
         username,
     });
 
+    // Repository team members bypass all GFI eligibility checks.
+    if (await isTeam({ github, owner, repo, username })) {
+        console.log('[has-gfi-eligibility] Skipped: user is team member', {
+            username,
+        });
+        return true;
+    }
+
     // Determine whether the contributor is listed in the spam list.
     // Spam-listed contributors are subject to stricter limits.
     const isSpamListed = await isOnSpamList({
@@ -74,11 +84,12 @@ const hasGfiEligibility = async ({
         maxAllowed,
     });
 
-    // If the contributor has reached or exceeded their allowed capacity,
-    // they are not eligible for assignment.
+    // Enforce assignment capacity limits
     if (openAssignedCount >= maxAllowed) {
         console.log('[has-gfi-eligibility] Exit: assignment limit reached', {
             username,
+            openAssignedCount,
+            maxAllowed,
         });
         return false;
     }

.github/scripts/lib/eligibility/has-eligibility-02-beginner.js

@@ -3,9 +3,11 @@
  * a Beginner issue in this repository.
  *
  * ELIGIBILITY RULES:
- * - Committers (write / maintain / admin) bypass all checks.
+ * - Repository team members (triage / write / maintain / admin)
+ *   bypass all eligibility and capacity checks.
  * - Contributors on the spam list are never eligible.
- * - Contributors must have completed at least one Good First Issue.
+ * - Contributors must have completed at least `REQUIRED_GFI_COUNT`
+ *   Good First Issues.
  * - Contributors may have fewer than `MAX_OPEN_ASSIGNED_ISSUES`
  *   open issue assignments.
  *
@@ -27,23 +29,23 @@
  * @param {string} params.username - GitHub username to check
  * @returns {Promise<boolean>} Whether the contributor may be assigned a Beginner issue
  */
-const { isCommitter } = require('./is-committer');
+const { isTeam } = require('./is-team');
 const { isOnSpamList } = require('../counts/is-on-spam-list');
 const { hasCompletedGfi } = require('./has-gfi');
-const { countOpenAssignedIssues } = require('./count-open-assigned-issues');
+const { countOpenAssignedIssues } = require('../counts/count-open-assigned-issues');
 
 /**
  * Maximum number of open issues allowed for Beginner eligibility.
  *
- * This value represents a policy decision and should be kept in sync
+ * This value represents a policy decision and must stay in sync
  * with guard messaging and documentation.
  */
 const MAX_OPEN_ASSIGNED_ISSUES = 2;
 
 /**
  * Number of Good First Issues required to qualify for Beginner issues.
  *
- * Expressed here explicitly to keep policy decisions out of helpers.
+ * Expressed explicitly to keep policy decisions out of helpers.
  */
 const REQUIRED_GFI_COUNT = 1;
 
@@ -60,9 +62,9 @@ const hasBeginnerEligibility = async ({
         username,
     });
 
-    // Committers bypass all Beginner eligibility checks.
-    if (await isCommitter({ github, owner, repo, username })) {
-        console.log('[has-beginner-eligibility] Skipped: user is committer', {
+    // Repository team members bypass all Beginner eligibility checks.
+    if (await isTeam({ github, owner, repo, username })) {
+        console.log('[has-beginner-eligibility] Skipped: user is team member', {
             username,
         });
         return true;
@@ -77,7 +79,7 @@ const hasBeginnerEligibility = async ({
     }
 
     // Enforce capacity limits for open issue assignments.
-    // This helper fails open, returning a large number on error,
+    // This helper fails open and returns a large number on error,
     // which conservatively blocks assignment.
     const openAssignedCount = await countOpenAssignedIssues({
         github,
@@ -95,8 +97,7 @@ const hasBeginnerEligibility = async ({
         return false;
     }
 
-    // Verify that the contributor has completed the required number
-    // of Good First Issues.
+    // Verify Good First Issue completion requirement.
     const hasRequiredGfi = await hasCompletedGfi({
         github,
         owner,

.github/scripts/lib/eligibility/has-eligibility-03-intermediate.js

@@ -2,18 +2,16 @@
  * Determines whether a contributor is eligible to be assigned
  * an Intermediate issue in this repository.
  *
- * ELIGIBILITY RULES (for non-triage contributors):
+ * ELIGIBILITY RULES:
+ * - Repository team members (triage / write / maintain / admin)
+ *   bypass all eligibility and capacity checks.
  * - Contributors on the spam list are never eligible.
  * - Contributors must have completed at least:
  *   - `REQUIRED_GFI_COUNT` Good First Issues
  *   - `REQUIRED_BEGINNER_COUNT` Beginner issues
  * - Contributors may have fewer than `MAX_OPEN_ASSIGNED_ISSUES`
  *   open issue assignments.
  *
- * EXEMPTION RULE:
- * - Triage members and above (triage / write / maintain / admin)
- *   bypass all eligibility checks and capacity limits.
- *
  * IMPORTANT NOTES:
  * - This helper is policy-only.
  * - It does NOT assign issues.
@@ -32,17 +30,17 @@
  * @param {string} params.username - GitHub username to check
  * @returns {Promise<boolean>} Whether the contributor may be assigned an Intermediate issue
  */
-const { isTriager } = require('./is-triager');
+const { isTeam } = require('./is-team');
 const { isOnSpamList } = require('../counts/is-on-spam-list');
 const { hasCompletedGfi } = require('./has-gfi');
 const { hasCompletedBeginner } = require('./has-beginner');
-const { countOpenAssignedIssues } = require('./count-open-assigned-issues');
+const { countOpenAssignedIssues } = require('../counts/count-open-assigned-issues');
 
 /**
  * Maximum number of open issues allowed for Intermediate eligibility.
  *
- * This value represents a policy decision and should be kept
- * in sync with guard messaging and documentation.
+ * This value represents a policy decision and must remain in sync
+ * with guard messaging and documentation.
  */
 const MAX_OPEN_ASSIGNED_ISSUES = 2;
 
@@ -71,20 +69,20 @@ const hasIntermediateEligibility = async ({
         username,
     });
 
-    // Contributors on the spam list are never eligible
-    if (await isOnSpamList({ github, owner, repo, username })) {
-        console.log('[has-intermediate-eligibility] Exit: user is on spam list', {
+    // Repository team members bypass all Intermediate eligibility checks.
+    if (await isTeam({ github, owner, repo, username })) {
+        console.log('[has-intermediate-eligibility] Skipped: user is team member', {
             username,
         });
-        return false;
+        return true;
     }
 
-    // Triage members and above bypass all eligibility checks
-    if (await isTriager({ github, owner, repo, username })) {
-        console.log('[has-intermediate-eligibility] Skipped: user is triage+', {
+    // Contributors on the spam list are never eligible.
+    if (await isOnSpamList({ github, owner, repo, username })) {
+        console.log('[has-intermediate-eligibility] Exit: user is on spam list', {
             username,
         });
-        return true;
+        return false;
     }
 
     // Enforce capacity limits for open issue assignments.
@@ -106,7 +104,7 @@ const hasIntermediateEligibility = async ({
         return false;
     }
 
-    // Verify Good First Issue completion requirement
+    // Verify Good First Issue completion requirement.
     const hasRequiredGfi = await hasCompletedGfi({
         github,
         owner,
@@ -123,7 +121,7 @@ const hasIntermediateEligibility = async ({
         return false;
     }
 
-    // Verify Beginner Issue completion requirement
+    // Verify Beginner Issue completion requirement.
     const hasRequiredBeginner = await hasCompletedBeginner({
         github,
         owner,
@@ -140,10 +138,11 @@ const hasIntermediateEligibility = async ({
         return false;
     }
 
-    // Contributor meets all Intermediate eligibility requirements
-    console.log('[has-intermediate-eligibility] Success: contributor eligible for Intermediate issues', {
-        username,
-    });
+    // Contributor meets all Intermediate eligibility requirements.
+    console.log(
+        '[has-intermediate-eligibility] Success: contributor eligible for Intermediate issues',
+        { username }
+    );
 
     return true;
 };

.github/scripts/lib/eligibility/has-eligibility-04-advanced.js

@@ -2,19 +2,17 @@
  * Determines whether a contributor is eligible to be assigned
  * an Advanced issue in this repository.
  *
- * ELIGIBILITY RULES (for non-committers):
+ * ELIGIBILITY RULES:
+ * - Committers (write / maintain / admin) bypass all eligibility
+ *   checks and capacity limits.
  * - Contributors on the spam list are never eligible.
  * - Contributors must have completed at least
  *   `REQUIRED_INTERMEDIATE_COUNT` Intermediate issues.
  * - Contributors may have fewer than `MAX_OPEN_ASSIGNED_ISSUES`
  *   open issue assignments.
  *
- * EXEMPTION RULE:
- * - Committers (write / maintain / admin) bypass all eligibility
- *   checks and capacity limits.
- * - Triage members are NOT exempt and must meet all requirements.
- *
  * IMPORTANT NOTES:
+ * - Triage members are NOT exempt and must meet all requirements.
  * - This helper is policy-only.
  * - It does NOT assign issues.
  * - It does NOT post comments.
@@ -34,8 +32,8 @@
  */
 const { isCommitter } = require('./is-committer');
 const { isOnSpamList } = require('../counts/is-on-spam-list');
-const { hasCompletedAdvanced } = require('./has-advanced');
-const { countOpenAssignedIssues } = require('./count-open-assigned-issues');
+const { hasCompletedIntermediate } = require('./has-intermediate');
+const { countOpenAssignedIssues } = require('../counts/count-open-assigned-issues');
 
 /**
  * Maximum number of open issues allowed for Advanced eligibility.
@@ -72,7 +70,7 @@ const hasAdvancedEligibility = async ({
         return true;
     }
 
-    // Contributors on the spam list are never eligible for Advanced issues.
+    // Contributors on the spam list are never eligible.
     if (await isOnSpamList({ github, owner, repo, username })) {
         console.log('[has-advanced-eligibility] Exit: user is on spam list', {
             username,
@@ -100,7 +98,7 @@ const hasAdvancedEligibility = async ({
     }
 
     // Verify Intermediate issue completion requirement.
-    const hasRequiredIntermediate = await hasCompletedAdvanced({
+    const hasRequiredIntermediate = await hasCompletedIntermediate({
         github,
         owner,
         repo,
@@ -120,9 +118,10 @@ const hasAdvancedEligibility = async ({
     }
 
     // Contributor meets all Advanced eligibility requirements.
-    console.log('[has-advanced-eligibility] Success: contributor eligible for Advanced issues', {
-        username,
-    });
+    console.log(
+        '[has-advanced-eligibility] Success: contributor eligible for Advanced issues',
+        { username }
+    );
 
     return true;
 };