fix: skip /assign reminder for repository collaborators [(hiero-ledger#1367)] (hiero-ledger#1420)

Signed-off-by: Parv Ninama <ninamaparv@gmail.com>

Author: parvninama

.github/scripts/bot-gfi-assign-on-comment.js

@@ -84,6 +84,57 @@ If you’d like to work on this **Good First Issue**, just comment:
 and you’ll be automatically assigned. Feel free to ask questions here if anything is unclear!`;
 }
 
+/// HELPERS TO DETECT COLLABORATORS ///
+
+function hasValidInputs({ github, owner, repo, username }) {
+    return Boolean(
+        github &&
+        typeof owner === 'string' &&
+        typeof repo === 'string' &&
+        typeof username === 'string' &&
+        owner &&
+        repo &&
+        username
+    );
+}
+
+function isPermissionFailure(error) {
+    return error?.status === 401 || error?.status === 403;
+}
+
+async function isRepoCollaborator({ github, owner, repo, username }) {
+    if (!hasValidInputs({ github, owner, repo, username })) {
+        console.log('[gfi-assign] isRepoCollaborator: invalid args', {
+            owner,
+            repo,
+            username,
+        });
+        return false;
+    }
+
+    try {
+        await github.rest.repos.checkCollaborator({
+            owner,
+            repo,
+            username,
+        });
+        return true; // 204 = collaborator
+    } catch (error) {
+        if (error?.status === 404 || isPermissionFailure(error)) {
+            if (isPermissionFailure(error)) {
+                console.log(
+                    '[gfi-assign] isRepoCollaborator: insufficient permissions; treating as non-collaborator',
+                    { owner, repo, username, status: error.status }
+                );
+            }
+            return false;
+        }
+        throw error; // unexpected error
+    }
+    
+}
+
+
 /// START OF SCRIPT ///
 module.exports = async ({ github, context }) => {
     try {
@@ -127,6 +178,20 @@ module.exports = async ({ github, context }) => {
                 issueIsGoodFirstIssue(issue) &&
                 !issue.assignees?.length
             ) {
+                const username = comment.user.login;
+
+                const isTeamMember = await isRepoCollaborator({
+                    github,
+                    owner,
+                    repo,
+                    username,
+                });
+
+                if (isTeamMember) {
+                    console.log('[gfi-assign] Skip reminder: commenter is collaborator');
+                    return;
+                }
+
                 const comments = await github.paginate(
                     github.rest.issues.listComments,
                     {

CHANGELOG.md

@@ -158,6 +158,7 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
 - Modified and renamed hasIntermediateOrAdvancedLabel() to check if issue label is beginner or higher (#1385)
 
 ### Fixed
+- Good First Issue bot no longer posts `/assign` reminders for repository collaborators. (#1367)
 - GFI workflow casing 
 - Update `bot-workflows.yml` to trigger only on open PRs with failed workflows; ignore closed PRs and branches without open PRs.
 - Fixed step-security/harden-runner action SHA in merge conflict bot workflow (#1278)