Merge pull request #135 from exploreriii/shared-libraries-guards

fix: attempt to fix spam messaging routing

Author: exploreriii

.github/scripts/lib/comments/rejection-router.js

@@ -2,7 +2,10 @@ const { beginnerRejection } = require('./difficulty-02-beginner');
 const { intermediateRejection } = require('./difficulty-03-intermediate');
 const { advancedRejection } = require('./difficulty-04-advanced');
 const { capacityLimitReached } = require('./max-assignments-reached');
-const { spamNonGfiAssignment } = require('./spam-restrictions');
+const {
+    spamNonGfiAssignment,
+    spamAssignmentLimitExceeded,
+} = require('./spam-restrictions');
 
 const REJECTION_REASONS =
     require('../eligibility/rejection-reasons');
@@ -28,14 +31,26 @@ const rejectionRouter = ({ reason, context = {}, username, urls = {} }) => {
                 browseIntermediateUrl: urls.intermediate,
             });
 
-        // ───── Shared rules
+        // ─────────────────────────────────────────
+        // Capacity limits (branch on spam status)
+        // ─────────────────────────────────────────
         case REJECTION_REASONS.CAPACITY:
+            if (context.isSpamListed) {
+                return spamAssignmentLimitExceeded(
+                    username,
+                    context.openAssignedCount
+                );
+            }
+
             return capacityLimitReached({
                 username,
                 openAssignedCount: context.openAssignedCount,
                 maxAllowed: context.maxAllowed,
             });
 
+        // ─────────────────────────────────────────
+        // Spam attempting non-GFI assignment
+        // ─────────────────────────────────────────
         case REJECTION_REASONS.SPAM:
             return spamNonGfiAssignment(username);
 

.github/scripts/lib/eligibility/has-eligibility-01-gfi.js

@@ -16,7 +16,12 @@ const hasGfiEligibility = async ({
         return { eligible: true };
     }
 
-    const isSpamListed = await isOnSpamList({ github, owner, repo, username });
+    const isSpamListed = await isOnSpamList({
+        github,
+        owner,
+        repo,
+        username,
+    });
 
     const maxAllowed = isSpamListed
         ? MAX_OPEN_ISSUES_SPAM_LIST
@@ -33,7 +38,11 @@ const hasGfiEligibility = async ({
         return {
             eligible: false,
             reason: REJECTION_REASONS.CAPACITY,
-            context: { openAssignedCount, maxAllowed },
+            context: {
+                openAssignedCount,
+                maxAllowed,
+                isSpamListed,
+            },
         };
     }