Skip to content

Commit f14bd73

Browse files
committed
chore: update rejection router
Signed-off-by: exploreriii <133720349+exploreriii@users.noreply.github.com>
1 parent 3fc6300 commit f14bd73

3 files changed

Lines changed: 22 additions & 7 deletions

File tree

.github/scripts/lib/comments/rejection-router.js

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,34 @@
11
const { beginnerRejection } = require('./difficulty-02-beginner');
2+
const { intermediateRejection } = require('./difficulty-03-intermediate');
3+
const { advancedRejection } = require('./difficulty-04-advanced');
24
const { capacityLimitReached } = require('./max-assignments-reached');
35
const { spamNonGfiAssignment } = require('./spam-restrictions');
46

57
const REJECTION_REASONS =
68
require('../eligibility/rejection-reasons');
79

8-
const rejectionRouter = ({ reason, context, username, urls }) => {
10+
const rejectionRouter = ({ reason, context = {}, username, urls = {} }) => {
911
switch (reason) {
12+
// ───── Beginner → Intermediate ladder
1013
case REJECTION_REASONS.MISSING_GFI:
11-
return beginnerRejection({
14+
case REJECTION_REASONS.MISSING_BEGINNER:
15+
return intermediateRejection({
1216
username,
13-
completedGfiCount: context.completedGfiCount,
17+
requiredGfiCount: context.requiredGfiCount ?? 1,
18+
requiredBeginnerCount: context.requiredBeginnerCount ?? 1,
1419
browseGfiUrl: urls.gfi,
20+
browseBeginnerUrl: urls.beginner,
1521
});
1622

23+
// ───── Intermediate → Advanced ladder
24+
case REJECTION_REASONS.MISSING_INTERMEDIATE:
25+
return advancedRejection({
26+
username,
27+
requiredIntermediateCount: context.requiredCount ?? 1,
28+
browseIntermediateUrl: urls.intermediate,
29+
});
30+
31+
// ───── Shared rules
1732
case REJECTION_REASONS.CAPACITY:
1833
return capacityLimitReached({
1934
username,

.github/workflows/bot-beginner-assign-on-comment.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ permissions:
1010
contents: read
1111

1212
jobs:
13-
gfi-assign:
13+
beginner-assign:
1414
# Only run on issue comments (not PR comments)
1515
if: github.event.issue.pull_request == null
1616

1717
runs-on: ubuntu-latest
1818

1919
# Prevent race conditions: always wait for the first assignment request to finish processing
2020
concurrency:
21-
group: gfi-assign-${{ github.event.issue.number }}
21+
group: beginner-assign-${{ github.event.issue.number }}
2222
cancel-in-progress: false
2323

2424
steps:

.github/workflows/bot-intermediate-assign-checker.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ permissions:
1010
contents: read
1111

1212
jobs:
13-
enforce-advanced:
13+
enforce-intermediate:
1414
runs-on: ubuntu-latest
1515

1616
concurrency:
17-
group: advanced-assign-${{ github.event.issue.number }}
17+
group: intermediate-assign-${{ github.event.issue.number }}
1818
cancel-in-progress: false
1919

2020
steps:

0 commit comments

Comments
 (0)