Skip to content

Commit f4d54ee

Browse files
authored
Merge pull request #153 from exploreriii/shared-libraries-guards
fix: undefined
2 parents eb89975 + 8fd7331 commit f4d54ee

4 files changed

Lines changed: 11 additions & 2 deletions

File tree

.github/scripts/lib/comments/rejection-router.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,10 @@ const rejectionRouter = ({ reason, context = {}, username, urls = {} }) => {
2828
case REJECTION_REASONS.MISSING_BEGINNER:
2929
return intermediateRejection({
3030
username,
31-
requiredBeginnerCount: context.requiredBeginnerCount ?? 1,
31+
completedBeginnerCount:
32+
context.completedBeginnerCount ?? 0,
33+
requiredBeginnerCount:
34+
context.requiredBeginnerCount ?? 1,
3235
browseBeginnerUrl: urls.beginner,
3336
});
3437

@@ -38,7 +41,10 @@ const rejectionRouter = ({ reason, context = {}, username, urls = {} }) => {
3841
case REJECTION_REASONS.MISSING_INTERMEDIATE:
3942
return advancedRejection({
4043
username,
41-
requiredIntermediateCount: context.requiredCount ?? 1,
44+
completedIntermediateCount:
45+
context.completedIntermediateCount ?? 0,
46+
requiredIntermediateCount:
47+
context.requiredIntermediateCount ?? 1,
4248
browseIntermediateUrl: urls.intermediate,
4349
});
4450

.github/scripts/lib/eligibility/has-eligibility-02-beginner.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ const hasBeginnerEligibility = async ({
135135
eligible: false,
136136
reason: REJECTION_REASONS.MISSING_GFI,
137137
context: {
138+
completedGfiCount: 0,
138139
requiredGfiCount: REQUIRED_GFI_COUNT,
139140
},
140141
};

.github/scripts/lib/eligibility/has-eligibility-03-intermediate.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ const hasIntermediateEligibility = async ({
136136
eligible: false,
137137
reason: REJECTION_REASONS.MISSING_BEGINNER,
138138
context: {
139+
completedBeginnerCount: 0,
139140
requiredBeginnerCount: REQUIRED_BEGINNER_COUNT,
140141
},
141142
};

.github/scripts/lib/eligibility/has-eligibility-04-advanced.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ const hasAdvancedEligibility = async ({
140140
eligible: false,
141141
reason: REJECTION_REASONS.MISSING_INTERMEDIATE,
142142
context: {
143+
completedIntermediateCount: 0,
143144
requiredIntermediateCount: REQUIRED_INTERMEDIATE_COUNT,
144145
},
145146
};

0 commit comments

Comments
 (0)