Fix RTL displaCy dependency labels#13981
Draft
lxingy3 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4854.
This updates the displaCy dependency renderer so dependency labels no longer depend on the SVG
sideattribute. Browser support forsideis inconsistent, which makes RTL dependency labels appear reversed or upside down in Chrome and Safari.The visible dependency arc is unchanged. The label now follows a separate invisible path, and RTL rendering reverses that label path so the text direction stays readable without relying on
side.Types of change
Bug fix.
Testing
python -m py_compile spacy\displacy\render.py spacy\displacy\templates.py spacy\tests\test_displacy.pygit diff --checkthincis missing before test collection).Checklist