extra_logging spaces and fix to player_died#417
Open
PHIDIAS0303 wants to merge 4 commits intoexplosivegaming:mainfrom
Open
extra_logging spaces and fix to player_died#417PHIDIAS0303 wants to merge 4 commits intoexplosivegaming:mainfrom
PHIDIAS0303 wants to merge 4 commits intoexplosivegaming:mainfrom
Conversation
Member
|
You should not add spaces to the strings, this is already handled by the concat function within add log line. Can you please describe the bug you are fixing as I do not see any change in logic by your code. |
Contributor
Author
|
L40 |
Member
This is not an explanation. I can see this is where you made an edit but how does checking the type make a difference when we already check if the by player is valid. What bug are you fixing with this additional if statement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.