fix: Use TSelectedFields for knex loader order by method#424
Merged
wschurman merged 1 commit intoFeb 12, 2026
Merged
Conversation
This was referenced Feb 6, 2026
Merged
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 108 108
Lines 14785 14869 +84
Branches 1288 745 -543
==========================================
+ Hits 14785 14869 +84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wschurman
force-pushed
the
wschurman/02-06-fix_use_tselectedfields_for_knex_loader_order_by_method
branch
from
February 9, 2026 23:28
844397b to
c475a0e
Compare
wschurman
force-pushed
the
wschurman/02-01-feat_add_sql_template_and_loader_method
branch
2 times, most recently
from
February 9, 2026 23:31
674d0b3 to
b8ff387
Compare
wschurman
force-pushed
the
wschurman/02-06-fix_use_tselectedfields_for_knex_loader_order_by_method
branch
from
February 9, 2026 23:31
c475a0e to
9de79ed
Compare
wschurman
changed the base branch from
wschurman/02-01-feat_add_sql_template_and_loader_method
to
graphite-base/424
February 9, 2026 23:57
wschurman
force-pushed
the
graphite-base/424
branch
from
February 10, 2026 00:01
b8ff387 to
273d1df
Compare
wschurman
force-pushed
the
wschurman/02-06-fix_use_tselectedfields_for_knex_loader_order_by_method
branch
from
February 10, 2026 00:01
9de79ed to
bacc551
Compare
wschurman
force-pushed
the
wschurman/02-06-fix_use_tselectedfields_for_knex_loader_order_by_method
branch
from
February 10, 2026 00:02
bacc551 to
8bc9c11
Compare
wschurman
marked this pull request as ready for review
February 10, 2026 00:12
wschurman
force-pushed
the
wschurman/02-06-fix_use_tselectedfields_for_knex_loader_order_by_method
branch
from
February 10, 2026 03:01
8bc9c11 to
2b671cb
Compare
This was referenced Feb 10, 2026
quinlanj
approved these changes
Feb 12, 2026
Member
Author
Merge activity
|
wschurman
deleted the
wschurman/02-06-fix_use_tselectedfields_for_knex_loader_order_by_method
branch
February 12, 2026 01:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Noticed while creating an upcoming pagination PR that loaders should use
TSelectedFieldsfororderByclauses. This was an accidental omission when the selected fields concept was added.Succinctly, one should only be able to order entities by their fields rather than by all their underlying table's fields.
How
Create new orderBy clause type that lives at the loader level. It is fully compatible (subset or equal to) the database orderBy clause, so calling the data manager methods directly with the arguments is by design.
Test Plan
yarn tsc