rename from SetCache to Bind

Author: diegommm

checker/checker.go

@@ -636,7 +636,7 @@ func (v *Checker) callNode(node *ast.CallNode) Nature {
 	// with new correct function return type.
 	if typ := node.Type(); typ != nil && typ != anyType {
 		nt := node.Nature()
-		nt.SetCache(&v.config.NtCache) // AST doesn't cache nature info
+		nt.Bind(&v.config.NtCache) // AST doesn't cache nature info
 		return nt
 	}
 

checker/info.go

@@ -16,7 +16,7 @@ func FieldIndex(c *Cache, env Nature, node ast.Node) (bool, []int, string) {
 		}
 	case *ast.MemberNode:
 		base := n.Node.Nature()
-		base.SetCache(c) // AST doesn't cache nature info
+		base.Bind(c) // AST doesn't cache nature info
 		base = base.Deref()
 		if base.Kind == reflect.Struct {
 			if prop, ok := n.Property.(*ast.StringNode); ok {

checker/nature/nature.go

@@ -137,7 +137,7 @@ func (c *Cache) getStruct(t reflect.Type) Nature {
 		},
 	}
 	if c != nil {
-		nt.SetCache(c)
+		nt.Bind(c)
 	}
 	return nt
 }
@@ -187,27 +187,30 @@ func ArrayFromType(c *Cache, t reflect.Type) Nature {
 	return nt
 }
 
-func (n *Nature) SetCache(c *Cache) {
+func (n *Nature) Bind(c *Cache) {
+	if n.cache == c {
+		return
+	}
 	n.cache = c
 	if n.Kind == reflect.Struct {
 		if c.structs == nil {
-			n.structData.setCache(c)
+			n.structData.bind(c)
 			c.structs = map[reflect.Type]Nature{
 				n.Type: *n,
 			}
 		} else if nt, ok := c.structs[n.Type]; ok {
 			// invalidate local, use shared from cache
 			n.Optional.structData = nt.Optional.structData
 		} else {
-			n.structData.setCache(c)
+			n.structData.bind(c)
 			c.structs[n.Type] = *n
 		}
 	}
 	hasMethodset := n.Optional != nil && n.Optional.methodset != nil
 	if c.methods != nil || hasMethodset {
 		if c.methods == nil {
 			// Cache is new and the type already gathered some methods
-			n.Optional.methodset.setCache(c)
+			n.Optional.methodset.bind(c)
 			c.methods = map[reflect.Type]*methodset{
 				n.Type: n.Optional.methodset,
 			}
@@ -219,7 +222,7 @@ func (n *Nature) SetCache(c *Cache) {
 			n.Optional.methodset = s
 		} else if hasMethodset {
 			// Cache miss and the type already gathered some methods
-			n.Optional.methodset.setCache(c)
+			n.Optional.methodset.bind(c)
 			c.methods[n.Type] = n.Optional.methodset
 		}
 	}

checker/nature/utils.go

@@ -32,10 +32,10 @@ type structField struct {
 	Index []int
 }
 
-func (s *structData) setCache(c *Cache) {
+func (s *structData) bind(c *Cache) {
 	s.cache = c
 	for _, sf := range s.fields {
-		sf.SetCache(c)
+		sf.Bind(c)
 	}
 }
 
@@ -204,10 +204,10 @@ type method struct {
 	nature Nature
 }
 
-func (s *methodset) setCache(c *Cache) {
+func (s *methodset) bind(c *Cache) {
 	s.cache = c
 	for _, m := range s.methods {
-		m.nature.SetCache(c)
+		m.nature.Bind(c)
 	}
 }
 

compiler/compiler.go

@@ -1089,7 +1089,7 @@ func (c *compiler) BuiltinNode(node *ast.BuiltinNode) {
 			c.compile(arg)
 			argType := arg.Type()
 			argNature := arg.Nature()
-			argNature.SetCache(c.ntCache) // AST doesn't cache nature info
+			argNature.Bind(c.ntCache) // AST doesn't cache nature info
 			if argType.Kind() == reflect.Ptr || argNature.IsUnknown() {
 				if f.Deref == nil {
 					// By default, builtins expect arguments to be dereferenced.

conf/config.go

@@ -50,7 +50,7 @@ func CreateNew() *Config {
 	for _, f := range builtin.Builtins {
 		c.Builtins[f.Name] = f
 	}
-	c.Env.SetCache(&c.NtCache)
+	c.Env.Bind(&c.NtCache)
 	return c
 }
 

conf/env.go

@@ -26,7 +26,7 @@ func EnvWithCache(c *Cache, env any) Nature {
 	switch env := env.(type) {
 	case types.Map:
 		nt := env.Nature()
-		nt.SetCache(c)
+		nt.Bind(c)
 		return nt
 	}
 
@@ -58,7 +58,7 @@ func EnvWithCache(c *Cache, env any) Nature {
 			switch face := face.(type) {
 			case types.Map:
 				nt := face.Nature()
-				nt.SetCache(c)
+				nt.Bind(c)
 				n.Fields[key.String()] = nt
 
 			default: