fix(fuzz): handle bare "invalid argument"#899
Merged
antonmedv merged 1 commit intoexpr-lang:masterfrom Jan 7, 2026
Merged
Conversation
OSS-Fuzz finding #471520156 had an assert caused by the time.LoadLocation outputting "invalid argument" for a null byte argument. The fuzz test was already intentionally skipping "invalid argument for" as a regex, which didn't match this err string. Changes: - Simplify regex to match both "invalid argument for X" and bare form - Remove redundant "operator in" pattern (covered by wildcard variant) Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OSS-Fuzz finding #471520156 had an assert caused by the
time.LoadLocationoutputting "invalid argument" for a null byte argument. The fuzz test was already intentionally skipping "invalid argument for" as a regex, which didn't match this err string.Changes
Further comments
The fuzz input in this case had a form of
date(' ',' ÿ ÿ ',' \x00 '). Thedatebuiltin callstime.LoadLocationlike:I would assume
timezonebuiltin is affected too.See this Go playground link how
time.LoadLocationworks.