replace on-finished with native stream.finished for request handling

Author: bjohansebas

lib/read.js

@@ -14,8 +14,8 @@
 var createError = require('http-errors')
 var getBody = require('raw-body')
 var iconv = require('iconv-lite')
-var onFinished = require('on-finished')
 var zlib = require('node:zlib')
+const { finished } = require('node:stream')
 
 /**
  * Module exports.
@@ -201,10 +201,10 @@ function createDecompressionStream (encoding, debug) {
  */
 
 function dump (req, callback) {
-  if (onFinished.isFinished(req)) {
+  if (req.writableEnded || req.writabledFinished) {
     callback(null)
   } else {
-    onFinished(req, callback)
+    finished(req, callback)
     req.resume()
   }
 }

lib/types/json.js

@@ -16,7 +16,6 @@ var bytes = require('bytes')
 var contentType = require('content-type')
 var createError = require('http-errors')
 var debug = require('debug')('body-parser:json')
-var isFinished = require('on-finished').isFinished
 var read = require('../read')
 var typeis = require('type-is')
 
@@ -100,7 +99,7 @@ function json (options) {
   }
 
   return function jsonParser (req, res, next) {
-    if (isFinished(req)) {
+    if (req.writableFinished) {
       debug('body already parsed')
       next()
       return

lib/types/raw.js

@@ -12,7 +12,6 @@
 
 var bytes = require('bytes')
 var debug = require('debug')('body-parser:raw')
-var isFinished = require('on-finished').isFinished
 var read = require('../read')
 var typeis = require('type-is')
 
@@ -54,7 +53,7 @@ function raw (options) {
   }
 
   return function rawParser (req, res, next) {
-    if (isFinished(req)) {
+    if (req.writableFinished) {
       debug('body already parsed')
       next()
       return

lib/types/text.js

@@ -13,7 +13,6 @@
 var bytes = require('bytes')
 var contentType = require('content-type')
 var debug = require('debug')('body-parser:text')
-var isFinished = require('on-finished').isFinished
 var read = require('../read')
 var typeis = require('type-is')
 
@@ -56,7 +55,7 @@ function text (options) {
   }
 
   return function textParser (req, res, next) {
-    if (isFinished(req)) {
+    if (req.writableFinished) {
       debug('body already parsed')
       next()
       return

lib/types/urlencoded.js

@@ -16,7 +16,6 @@ var bytes = require('bytes')
 var contentType = require('content-type')
 var createError = require('http-errors')
 var debug = require('debug')('body-parser:urlencoded')
-var isFinished = require('on-finished').isFinished
 var read = require('../read')
 var typeis = require('type-is')
 var qs = require('qs')
@@ -72,7 +71,7 @@ function urlencoded (options) {
   }
 
   return function urlencodedParser (req, res, next) {
-    if (isFinished(req)) {
+    if (req.writableEnded || req.writableFinished) {
       debug('body already parsed')
       next()
       return