Skip to content

replace on-finished with native stream.finished for request handling #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjohansebas wants to merge 1 commit into from
Closed

replace on-finished with native stream.finished for request handling #598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/read.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
var createError = require('http-errors')
var getBody = require('raw-body')
var iconv = require('iconv-lite')
var onFinished = require('on-finished')
var zlib = require('node:zlib')
const { finished } = require('node:stream')

/**
* Module exports.
Expand Down Expand Up @@ -201,10 +201,10 @@
*/

function dump (req, callback) {
if (onFinished.isFinished(req)) {

Check failure on line 204 in lib/read.js

View workflow job for this annotation

GitHub Actions / Lint 

'onFinished' is not defined
callback(null)
} else {
onFinished(req, callback)
Copy link
Copy Markdown
Member Author

@bjohansebas bjohansebas Apr 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened an issue in Node to fix the tests that are failing due to this change.

nodejs/node#57844

finished(req, callback)
req.resume()
}
}
Loading