Skip to content

Commit 166e5f8

Browse files
kjugiUlisesGascon
andauthored
Apply suggestions from code review
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
1 parent 43b0ed8 commit 166e5f8

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

docs/adr/isomorphism-support.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ Future issues can be closed with a link to this document.
4545

4646
## Rationale
4747

48-
CommonJS is the default node.js syntax. The JS world moved in the ESM direction as browsers consumed it well, and bundlers could make a tree-shake feature and dynamic imports. There is still a lot of baggage within the ESM itself and the way how we can use it.
48+
CommonJS is the default syntax in Node.js. While the JavaScript ecosystem has increasingly moved toward ESM due to its compatibility with browsers, enhanced tree-shaking capabilities, and support for dynamic imports, there are still complexities and challenges associated with ESM.
4949

50-
To keep it short it's a whole new chapter to discuss and consider so it could use a lot of time and resources to make it properly. Don't get this wrong - it's not impossible tho! Most of our users will use the package in their project and pass it to the bundler which will produce the right format without any issues.
50+
Adopting ESM for our libraries would require a significant investment of time and resources to ensure proper implementation and long-term maintenance. While it is not impossible to achieve, it represents a considerable effort. Moreover, the majority of our users already utilize our libraries in their projects, relying on bundlers to handle the necessary transformations without issues.
5151

5252
- **Alternatives Considered:**
5353
- Alternative 1: Add ESM export to our libraries. CommonJS format is accepted by all most popular bundlers.

0 commit comments

Comments
 (0)