ci: update workflows (#1924)

* ci: update CI workflows to handle pull request reviews

Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

* chore: update codeowners

Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

* Update .github/workflows/ci.yml

---------

Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>

Author: bjohansebas

.github/CODEOWNERS

@@ -1,5 +1,5 @@
 # Website development
-* @expressjs/docs-captains @expressjs/docs-collaborators
+* @expressjs/docs-collaborators
 
 # Codeowners
 .github/CODEOWNERS @expressjs/docs-captains

.github/workflows/ci.yml

@@ -4,6 +4,8 @@ on:
   pull_request:
     branches:
     - gh-pages
+  pull_request_review:
+      types: [submitted]
   push:
     branches:
     - gh-pages
@@ -14,32 +16,50 @@ permissions:
 jobs:
   test:
     runs-on: ubuntu-latest
+    if: |
+      github.event.pull_request.draft != true &&
+      (github.event_name == 'pull_request_review' && github.event.review.state == 'approved') ||
+      github.event_name != 'pull_request_review'
 
     steps:
     - uses: actions/checkout@v4
-
-    - name: Setup Ruby    
-      uses: ruby/setup-ruby@13e7a03dc3ac6c3798f4570bfead2aed4d96abfb # https://github.com/ruby/setup-ruby/releases/tag/v1.244.0
       with:
-        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+        persist-credentials: false
+ 
 
     - name: Set up Node.js
       uses: actions/setup-node@v4
-      with:
-        node-version: 20
 
     - name: Install Node.js dependencies
       run: npm install
 
     - name: Run tests
       shell: bash
       run: npm test
-    
-    - name: Jekyll Build
-      run: bundle exec jekyll build
 
-    - name: Check Docker support
-      shell: bash
-      run: |
-        docker --version
-        make build
+  build:
+    name: Build
+    runs-on: ubuntu-latest
+    if: |
+      github.event.pull_request.draft != true &&
+      (github.event_name == 'pull_request_review' && github.event.review.state == 'approved') ||
+      github.event_name != 'pull_request_review'
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+
+      - name: Setup Ruby    
+        uses: ruby/setup-ruby@4a9ddd6f338a97768b8006bf671dfbad383215f4 # https://github.com/ruby/setup-ruby/releases/tag/v1.207.0
+        with:
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+
+      - name: Jekyll Build
+        run: bundle exec jekyll build
+
+      - name: Check Docker support
+        shell: bash
+        run: |
+          docker --version
+          make build

.github/workflows/crowdin.yml

@@ -15,6 +15,8 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          persist-credentials: false
 
       - name: crowdin action
         uses: crowdin/github-action@b8012bd5491b8aa8578b73ab5b5f5e7c94aaa6e2 # https://github.com/crowdin/github-action/releases/tag/v2.7.0

.github/workflows/update-external-docs.yml

@@ -15,28 +15,30 @@ jobs:
         if: github.repository_owner == 'expressjs'
         steps:
             - uses: actions/checkout@v4
+
             - name: Set up Node.js
               uses: actions/setup-node@v4
-              with:
-                node-version: 20
+
             - name: Run scripts
               working-directory: .github/scripts
               run: |
                 bash ./get-contributing.sh
                 bash ./get-readmes.sh
                 node ./get-express-version.mjs  
+
             - name: Create Pull Request
               uses: gr2m/create-or-update-pull-request-action@v1
               env:
                 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
               with: 
-                commit-message: update external docs
-                title: 'Update external docs'
+                commit-message: 'docs: update external docs'
+                title: 'docs: update external docs'
                 body: >
-                  This auto-generated PR updates external documentation to the expressjs.com repository.
-                labels: doc
-                team_reviewers: expressjs/docs-captains
-                branch: external-docs-${{ github.sha }}
+                  This auto-generated PR updates external documentation to the expressjs.com repository. 
+                  
+                  cc: @expressjs/docs-wg
+                labels: docs
+                branch: external-docs
 
     synchronize-with-crowdin:
         runs-on: ubuntu-latest