Merged
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
Doing this is also important so that we can fully translate the website from Crowdin |
carlosstenzel
approved these changes
Feb 11, 2025
ctcpip
reviewed
Feb 11, 2025
ctcpip
requested changes
Feb 11, 2025
Member
ctcpip
left a comment
ctcpip
left a comment
There was a problem hiding this comment.
We should not remove them until we have updated the translations. Until then, it's still true that the translations were done by IBM.
Member
Author
|
Blocked until #1777 is launched. |
Member
|
Is this still a thing? #1777 is closed, but I am not clear how those are connected. |
Member
Author
|
I'm still fixing some errors in the translations, I can continue with the translations next week. |
Member
|
Blocked until #1874 |
bjohansebas
force-pushed
the
remove-strongloop
branch
from
26b29af to
1bcf921
Compare
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Member
Author
|
@expressjs/express-tc, @ctcpip, please take a look. |
ShubhamOulkar
approved these changes
Jun 21, 2025
…into remove-strongloop
ctcpip
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message it had gave the impression that IBM/StrongLoop is still handling the translations for those languages. If there are no objections from @expressjs/express-tc, we can merge this PR. Rand agrees to remove it if there are no objections.
Additionally, I added a section in the README to acknowledge and give proper credit.
Once this is merged, I can continue with #1768.
cc: @expressjs/express-tc @expressjs/docs-wg