Normalize i18n notice translation#1930
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I think we need to do this step manually for now, since it would be unusual for the alert to appear without text or we could probably implement some logic to check if the string exists, and if not, fall back to the English one |
added in 1b42b97 |
That was the doubt I forgot to include in the description. Maybe doing it manually in Crowdin is the only option. |
We can’t, because the link is dynamic. |
|
Although we can probably remove the banner, right? @expressjs/docs-wg WDYT? |
|
The issue is fixed in cd1fba0. |
bjohansebas
left a comment
There was a problem hiding this comment.
LGTM, let's leave this open a bit longer.
|
thanks @ShubhamOulkar! |


closes #1768
related pr #1779
Right now it shows an empty notice box, but the notice will populate once translation is updated by Crowdin.