-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: Improve language picker UI with icons #1933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ShubhamOulkar
wants to merge
18
commits into
expressjs:gh-pages
from
ShubhamOulkar:enhance-lang-picker
Closed
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a3be719
add icons for all languages
ShubhamOulkar ab71fb9
add language icons for mobile
ShubhamOulkar 2dc8849
remove duplicate ID's from lang menu
ShubhamOulkar 90a96c5
remove development testing code
ShubhamOulkar 71bb25c
code linting
ShubhamOulkar adb7f84
Merge branch 'gh-pages' into enhance-lang-picker
ShubhamOulkar 6536023
document svg flag icons
ShubhamOulkar c840a1f
Fix bug in current language highlighting logic
ShubhamOulkar 34b40ed
refactor css: bug fix and remove unused css selector
ShubhamOulkar c37b3a4
use page url to render language flags
ShubhamOulkar 8605cd4
Merge branch 'gh-pages' into enhance-lang-picker
ShubhamOulkar 3e33297
Merge branch 'gh-pages' into enhance-lang-picker
ShubhamOulkar c1b66a5
Merge branch 'gh-pages' into enhance-lang-picker
ShubhamOulkar 2d67656
remove flags
ShubhamOulkar 298e9db
add translation global svg icon
ShubhamOulkar db838b5
fix CSS
ShubhamOulkar f55366a
remove docs on svg flag icons
ShubhamOulkar 75031e4
apply default i18n icon and remove down arrow
ShubhamOulkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.